771574 - New Crash Report Annotation Line Item Request

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Mark Capella [:capella]]

Accessibility would like to have a new line item field appear on the crash reports indicating if A11y was "Active" at the time of a crash.

This is in reference to Bug 769302 - Please add about:support accessibility status to crash reports, and our code to generate would simply resemble:

#if defined(MOZ_CRASHREPORTER)
  CrashReporter::AnnotateCrashReport(NS_LITERAL_CSTRING("Accessibility"),
                                     NS_LITERAL_CSTRING("Active"));
#endif

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Mark do we still need bug 769302?

Comment 2

[Mark Capella [:capella]]

Well this is new to me... I thought we had that bug for changes to our stuff (nsaccessibilityservice.cpp) and this one was for Socorro matching / supporting changes ...

I suppose it could all be done on one bug, but someone would have to edjukate me to the "standard" procedure :)

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Two bugs is fine :) It just wasn't clear to me what is happening on this bug.

Comment 4

[Schalk Neethling [:espressive]]

[:capella] Has the additional field been added to the raw JSON?

Comment 5

[Trevor Saunders (:tbsaunde)]

(In reply to Schalk Neethling [:espressive] from comment #4)
> [:capella] Has the additional field been added to the raw JSON?

I believe it should as of todays nightly, assuming that's what CrashReporter::AnnotateCrashReport() does that.

Comment 6

[Schalk Neethling [:espressive]]

Sent pull request:
https://github.com/mozilla/socorro/pull/720

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/a49e33e2d3f3c87adbb599f1592cebd2a4f3a57b
adding Accessibility to crash dump white list and report UI fixes bug 771574

https://github.com/mozilla/socorro/commit/c67c0195b920d575a3de2336b71ce6e8be365850
Merge pull request #720 from ossreleasefeed/new-accessibility-crash-report-annotation-771574

adding Accessibility to crash dump white list and report UI fixes bug 771574

Comment 8

[David Bolter [:davidb] (NeedInfo me for attention)]

Can someone point me to an example crash report to verify?

Comment 9

[Schalk Neethling [:espressive]]

Hey David,

Adding :kairo to the CC list, I am sure he will be able to assist here.

Comment 10

[Robert Kaiser]

Just stumbled across https://crash-stats.allizom.org/report/index/f5585c58-5182-4c32-abcc-c6ebc2120812 on staging, and it has this annotation displayed. :)

Comment 11

[Schalk Neethling [:espressive]]

This is a good thing right?

Comment 12

[Matt Brandt [:mbrandt]]

QA verified on stage per kairo's url in comment 10.. thanks all!

Comment 13

[David Bolter [:davidb] (NeedInfo me for attention)]

Sorry I missed comment 10. Thanks!