Last Comment Bug 771595 - Gonk widget fails to initialize the framebuffer if GL context creation fails
: Gonk widget fails to initialize the framebuffer if GL context creation fails
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Widget: Gonk (show other bugs)
: Trunk
: ARM Gonk (Firefox OS)
: -- normal (vote)
: mozilla16
Assigned To: Marshall Culpepper [:marshall_law]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-06 11:24 PDT by Marshall Culpepper [:marshall_law]
Modified: 2012-07-08 19:22 PDT (History)
8 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Framebuffer fallback on !sGLContext (2.66 KB, patch)
2012-07-06 12:08 PDT, Marshall Culpepper [:marshall_law]
no flags Details | Diff | Splinter Review
Framebuffer fallback on !sGLContext - v2 (3.83 KB, patch)
2012-07-06 12:43 PDT, Marshall Culpepper [:marshall_law]
cjones.bugs: review+
Details | Diff | Splinter Review
Framebuffer fallback on !sGLContext - v2 (rebased) (3.74 KB, patch)
2012-07-06 15:38 PDT, Marshall Culpepper [:marshall_law]
no flags Details | Diff | Splinter Review

Description Marshall Culpepper [:marshall_law] 2012-07-06 11:24:39 PDT
In AOSP qemu, the fallback software rendering EGL lib doesn't support GLES 2.0, which means the GL context isn't created by GLContextProviderEGL.

Currently, accelerated rendering and the framebuffer are only initialized before the attempt to create the GL context. 

The fix is to wait until _after_ attempting to create the GL context before checking whether the framebuffer needs to be initialized, and then appropriately set the |mUseAcceleratedRendering| flag..

(Note: move this to Widget: Gonk component once it's created in Bug 771591)
Comment 1 Marshall Culpepper [:marshall_law] 2012-07-06 11:26:12 PDT
The 2nd half of the emulator black screen issue on B2G github:
https://github.com/mozilla-b2g/B2G/issues/51
Comment 2 Marshall Culpepper [:marshall_law] 2012-07-06 12:08:10 PDT
Created attachment 639755 [details] [diff] [review]
Framebuffer fallback on !sGLContext
Comment 3 Marshall Culpepper [:marshall_law] 2012-07-06 12:43:07 PDT
Created attachment 639762 [details] [diff] [review]
Framebuffer fallback on !sGLContext - v2
Comment 4 Marshall Culpepper [:marshall_law] 2012-07-06 15:38:49 PDT
Created attachment 639836 [details] [diff] [review]
Framebuffer fallback on !sGLContext - v2 (rebased)

Rebased
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-07-07 07:09:14 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/71be75e10f5f
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-07-07 11:59:33 PDT
https://hg.mozilla.org/mozilla-central/rev/71be75e10f5f

Note You need to log in before you can comment on or make changes to this bug.