Closed
Bug 771677
Opened 10 years ago
Closed 10 years ago
Error setting SuggestClient in testSearchSuggestions
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 16
People
(Reporter: bnicholson, Assigned: bnicholson)
References
Details
Attachments
(1 file)
4.26 KB,
patch
|
gbrown
:
review+
|
Details | Diff | Splinter Review |
Caused by the patches in bug 769145. mSuggestClient was moved from AwesomeBar to AllPagesTab, so we need to update the test case accordingly.
Assignee | ||
Comment 1•10 years ago
|
||
Uses mSuggestClient in AllPagesTab rather than AwesomeBar.
Attachment #639850 -
Flags: review?(gbrown)
![]() |
||
Comment 2•10 years ago
|
||
Comment on attachment 639850 [details] [diff] [review] patch Review of attachment 639850 [details] [diff] [review]: ----------------------------------------------------------------- I tried to run testSearchSuggestions with this patch + the 2 patches from bug769145, but still had trouble. Still, this looks fine to me, so r+ assuming you can run testSearchSuggestions successfully.
Attachment #639850 -
Flags: review?(gbrown) → review+
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Geoff Brown [:gbrown] from comment #2) > Comment on attachment 639850 [details] [diff] [review] > patch > > Review of attachment 639850 [details] [diff] [review]: > ----------------------------------------------------------------- > > I tried to run testSearchSuggestions with this patch + the 2 patches from > bug769145, but still had trouble. Still, this looks fine to me, so r+ > assuming you can run testSearchSuggestions successfully. Just ran again locally to be sure, and it passed. Hopefully tbpl agrees. https://hg.mozilla.org/integration/mozilla-inbound/rev/69270e84853e
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/69270e84853e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Updated•2 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•