771677 - Error setting SuggestClient in testSearchSuggestions

Status: RESOLVED FIXED

(Firefox for Android :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

Caused by the patches in bug 769145. mSuggestClient was moved from AwesomeBar to AllPagesTab, so we need to update the test case accordingly.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: patch

Uses mSuggestClient in AllPagesTab rather than AwesomeBar.

Comment 2

[Geoff Brown [:gbrown]]

Comment on attachment 639850 [details] [diff] [review]
patch

Review of attachment 639850 [details] [diff] [review]:
-----------------------------------------------------------------

I tried to run testSearchSuggestions with this patch + the 2 patches from bug769145, but still had trouble. Still, this looks fine to me, so r+ assuming you can run testSearchSuggestions successfully.

Comment 3

[Brian Nicholson (:bnicholson)]

(In reply to Geoff Brown [:gbrown] from comment #2)
> Comment on attachment 639850 [details] [diff] [review]
> patch
> 
> Review of attachment 639850 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I tried to run testSearchSuggestions with this patch + the 2 patches from
> bug769145, but still had trouble. Still, this looks fine to me, so r+
> assuming you can run testSearchSuggestions successfully.

Just ran again locally to be sure, and it passed. Hopefully tbpl agrees.

https://hg.mozilla.org/integration/mozilla-inbound/rev/69270e84853e

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/69270e84853e