Error setting SuggestClient in testSearchSuggestions

RESOLVED FIXED in Firefox 16

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bnicholson, Assigned: bnicholson)

Tracking

unspecified
Firefox 16
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Caused by the patches in bug 769145. mSuggestClient was moved from AwesomeBar to AllPagesTab, so we need to update the test case accordingly.
(Assignee)

Comment 1

6 years ago
Created attachment 639850 [details] [diff] [review]
patch

Uses mSuggestClient in AllPagesTab rather than AwesomeBar.
Attachment #639850 - Flags: review?(gbrown)
Comment on attachment 639850 [details] [diff] [review]
patch

Review of attachment 639850 [details] [diff] [review]:
-----------------------------------------------------------------

I tried to run testSearchSuggestions with this patch + the 2 patches from bug769145, but still had trouble. Still, this looks fine to me, so r+ assuming you can run testSearchSuggestions successfully.
Attachment #639850 - Flags: review?(gbrown) → review+
(Assignee)

Comment 3

6 years ago
(In reply to Geoff Brown [:gbrown] from comment #2)
> Comment on attachment 639850 [details] [diff] [review]
> patch
> 
> Review of attachment 639850 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I tried to run testSearchSuggestions with this patch + the 2 patches from
> bug769145, but still had trouble. Still, this looks fine to me, so r+
> assuming you can run testSearchSuggestions successfully.

Just ran again locally to be sure, and it passed. Hopefully tbpl agrees.

https://hg.mozilla.org/integration/mozilla-inbound/rev/69270e84853e
https://hg.mozilla.org/mozilla-central/rev/69270e84853e
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
You need to log in before you can comment on or make changes to this bug.