Clicking "Compare Selected Revisions" with no revisions selected triggers 404

VERIFIED FIXED

Status

P2
normal
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: davidwalsh, Assigned: davidwalsh)

Tracking

Details

(Assignee)

Description

6 years ago
We should probably detect this and just send them back to the compare page.
Better yet, maybe we could disable the button until two different revisions are selected.

Updated

6 years ago
Blocks: 756266
Priority: -- → P2
(Assignee)

Updated

6 years ago
Assignee: nobody → dwalsh

Comment 2

6 years ago
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/f3d7e33b190d7ab5085cee81dec7a11b4450ec32
fix bug 771722 - Don't allow revision selection without more than one rev

https://github.com/mozilla/kuma/commit/b4e87ca4df1bc80f90ca47fb80f8731d886c1dd6
Merge pull request #505 from darkwing/revision-radios-771722

fix bug 771722 - Don't allow revision selection without more than one rev

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
verified fixed https://developer.allizom.org/en-US/docs/onetwo$history
Status: RESOLVED → VERIFIED
Version: Kuma → unspecified
Component: Docs Platform → Editing
Product: Mozilla Developer Network → Mozilla Developer Network
No longer blocks: 756266
You need to log in before you can comment on or make changes to this bug.