Closed Bug 771733 Opened 9 years ago Closed 9 years ago

content description in tabs button in wrong in single tab states.

Categories

(Firefox for Android Graveyard :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 16

People

(Reporter: eeejay, Assigned: eeejay)

Details

(Keywords: access)

Attachments

(1 file, 1 obsolete file)

The screen reader says "1 tabs".
(In reply to Margaret Leibovic [:margaret] from comment #1)
> Well then, this comment is obviously wrong:
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/locales/en-
> US/android_strings.dtd#57

Maybe not worded correctly. That string could only be used when number of tabs is more than one.
This is not perfect. Using the "new tab" string that is already there. This should be good enough for aurora. For m-c we should follow up with a patch that removes that string, and add a new one (in en-US, "1 tab").
Attachment #640680 - Flags: review?(sriram)
Comment on attachment 640680 [details] [diff] [review]
Don't use plural tabs description in tabs button when only one tab exists.

Will put in a patch with a new string for ff16. This won't be fixed for Aurora.
Attachment #640680 - Attachment is obsolete: true
Attachment #640680 - Flags: review?(sriram)
Yeah, for Aurora this is not critical. Annoying perhaps, but if we put in a proper fix for 16, it's OK.
Comment on attachment 641206 [details] [diff] [review]
Bug 771733 - Don't use plural tabs description in tabs button when only one tab exists.

Review of attachment 641206 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #641206 - Flags: review?(sriram) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/a2a27bb34f23
Assignee: nobody → eitan
Target Milestone: --- → Firefox 16
https://hg.mozilla.org/mozilla-central/rev/a2a27bb34f23
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified fixed in Firefox/Android 16.0a1 2012-07-13
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.