771733 - content description in tabs button in wrong in single tab states.

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Eitan Isaacson [:eeejay]]

The screen reader says "1 tabs".

Comment 1

[:Margaret Leibovic]

Well then, this comment is obviously wrong:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/locales/en-US/android_strings.dtd#57

Comment 2

[Eitan Isaacson [:eeejay]]

(In reply to Margaret Leibovic [:margaret] from comment #1)
> Well then, this comment is obviously wrong:
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/locales/en-
> US/android_strings.dtd#57

Maybe not worded correctly. That string could only be used when number of tabs is more than one.

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: Don't use plural tabs description in tabs button when only one tab exists.

This is not perfect. Using the "new tab" string that is already there. This should be good enough for aurora. For m-c we should follow up with a patch that removes that string, and add a new one (in en-US, "1 tab").

Comment 4

[Eitan Isaacson [:eeejay]]

Comment on attachment 640680 [details] [diff] [review]
Don't use plural tabs description in tabs button when only one tab exists.

Will put in a patch with a new string for ff16. This won't be fixed for Aurora.

Comment 5

[Marco Zehe (:MarcoZ)]

Yeah, for Aurora this is not critical. Annoying perhaps, but if we put in a proper fix for 16, it's OK.

Comment 6

[Eitan Isaacson [:eeejay]]

Attachment: Bug 771733 - Don't use plural tabs description in tabs button when only one tab exists.

This would be for Firefox 16.

Comment 7

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 641206 [details] [diff] [review]
Bug 771733 - Don't use plural tabs description in tabs button when only one tab exists.

Review of attachment 641206 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 8

[Eitan Isaacson [:eeejay]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/a2a27bb34f23

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a2a27bb34f23

Comment 10

[Marco Zehe (:MarcoZ)]

Verified fixed in Firefox/Android 16.0a1 2012-07-13