Last Comment Bug 771844 - about:memory should have a larger max width
: about:memory should have a larger max width
Status: RESOLVED FIXED
:
Product: Toolkit
Classification: Components
Component: about:memory (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: :Gavin Sharp [email: gavin@gavinsharp.com]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-07 16:05 PDT by :Gavin Sharp [email: gavin@gavinsharp.com]
Modified: 2012-07-09 06:36 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.02 KB, patch)
2012-07-07 16:06 PDT, :Gavin Sharp [email: gavin@gavinsharp.com]
n.nethercote: review+
Details | Diff | Splinter Review

Description :Gavin Sharp [email: gavin@gavinsharp.com] 2012-07-07 16:05:42 PDT
This can be easily achieved by setting class "aboutPageWideContainer" on the body. More room to see long URLs and such on wide screen monitors.
Comment 1 :Gavin Sharp [email: gavin@gavinsharp.com] 2012-07-07 16:06:52 PDT
Created attachment 640001 [details] [diff] [review]
patch
Comment 2 :Gavin Sharp [email: gavin@gavinsharp.com] 2012-07-07 16:09:46 PDT
Before patch: http://cl.ly/391e2B1u2H3E381F1o2U
After patch: http://cl.ly/463L1i3V3c3M0O3l3l1Z
Comment 3 Nicholas Nethercote [:njn] 2012-07-08 04:09:12 PDT
Comment on attachment 640001 [details] [diff] [review]
patch

Review of attachment 640001 [details] [diff] [review]:
-----------------------------------------------------------------

jlebar is the CSS expert when it comes to about:memory, but I reckon I can r+ this :)
Comment 4 Justin Lebar (not reading bugmail) 2012-07-08 07:08:57 PDT
I think we should make the compartment URLs appear again in the tooltips.  I miss those.

But that's a separate bug; this looks good.  :)
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-07-08 17:50:07 PDT
https://hg.mozilla.org/mozilla-central/rev/1c58f5b42d42
Comment 6 Michael Foerster 2012-07-09 06:36:06 PDT
(In reply to Justin Lebar [:jlebar] from comment #4)
> I think we should make the compartment URLs appear again in the tooltips.  I
> miss those.
> 
> But that's a separate bug; this looks good.  :)

+1 for the tooltips, esp as there is now even more information and thus longer lines.

IMHO tooltips are only needed for lines with more than 50-60 chars (old width was 50em)

Thanks for the patch. Until now I've had the line:
body.non-verbose { max-width: 90% !important; }
in my chrome/userContent.css file.

Note You need to log in before you can comment on or make changes to this bug.