771850 - Migrate Theme submission to Marketplace

Status: RESOLVED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P1)

Description

[Christopher Van Wiemeersch [:cvan]]

Attachment: Current Persona submission flow

Personas can currently be uploaded at https://addons-dev.allizom.org/en-US/developers/persona/submit

We want this to instead live at https://marketplace-dev.allizom.org/en-US/developers/persona/submit

Please use the Marketplace Developer Hub style. Ask cvan if you have questions.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Kevin has this pretty much done. I've seen it.

Comment 2

[Andy McKay]

Is the marketplace the best place for this? Would it make more sense to be in AMO? That would be the quickest path to getting rid of getpersonas.

Comment 3

[Andrew Williamson [:eviljeff]]

(In reply to Andy McKay [:andym] from comment #2)
> Is the marketplace the best place for this? Would it make more sense to be
> in AMO? That would be the quickest path to getting rid of getpersonas.

I wasn't involved in the decision (I imagine Wil and Fligtar were) but I understand the reasoning was that as both Addons and Themes/Personas are eventually going to be on Marketplace, it didn't make sense to put the work to migrate to AMO, and then a few months later have to rewrite it to migrate to Marketplace.

Comment 4

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/zamboni/commit/7756c230b8ba1a98d02a37c90b659ae9fdc6b77f

Comment 5

[Kevin Ngo [:ngoke]]

at /developers/submit/theme

Comment 6

[Andrew Williamson [:eviljeff]]

Looks nice but unfortunately I couldn't get it to work.

This error (from the console) might be relevant:
[11:53:36.362] Form contains a file input, but is missing method=POST and enctype=multipart/form-data on the form.  The file will not be sent. @ https://marketplace-dev.allizom.org/developers/submit/theme

Also, when the submission didn't complete due to above (and I was returned to the same page) the licensing radio inputs didn't retain their values.

Comment 7

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/zamboni/commit/49f067d207fe6ef74c487793fb4ff4a0524d5f8e

Attempted fix.

Comment 8

[Amy Tsay [:amyt]]

When there is a form validation error, i.e. when the name you pick is already taken, the form makes you upload the images again. This is a major pain point as it's sometimes necessary to try a few names before you get one that is unique.

Comment 9

[BrianZ]

Agree that it's a real pain from a usability standpoint.  Is a unique name really necessary when there is already a unique ID number?  If not, how much trouble would it be to fix this to allow a non-unique name?  Thanks.

Comment 10

[Andrew Williamson [:eviljeff]]

(In reply to BrianZ from comment #9)
> Is a unique name really necessary when there is already a unique ID number?  

Yes.  You should be able to find something from its name without having to have an exact url.

Comment 11

[BrianZ]

Why would a search not allow you to find a persona without a unique name?  Words or titles should not be reserved for a single add-on.

Comment 12

[Andy McKay]

In reply to comment #3.

I just feel the single and only focus should be shipping marketplace. The "merge" has been bumped so far into the future, who knows when it will happen. If we put personas onto amo, it will be there way, way sooner.

Comment 13

[Christopher Van Wiemeersch [:cvan]]

(In reply to Andy McKay [:andym] from comment #12)
> In reply to comment #3.
> 
> I just feel the single and only focus should be shipping marketplace.

It still is, yeah

> The "merge" has been bumped so far into the future, who knows when it will
> happen. If we put personas onto amo, it will be there way, way sooner.

I think the product call was to move themes entirely to Marketplace (without add-ons), and launch both. With Kevin gone, we won't have anyone actively working on themes so this is likely to get neglected pretty soon.

Comment 14

[Christopher Van Wiemeersch [:cvan]]

771850(In reply to Amy Tsay [:amyt] from comment #8)
> When there is a form validation error, i.e. when the name you pick is
> already taken, the form makes you upload the images again. This is a major
> pain point as it's sometimes necessary to try a few names before you get one
> that is unique.

Fixed it (for both AMO+Marketplace) so that we properly remember header+footer images and text+background colors even when there are form errors:

https://github.com/mozilla/zamboni/commit/38a663f
https://github.com/mozilla/zamboni/commit/9b748c8

For any additional issues with the flow, please file new bugs :)

Comment 15

[Andrew Williamson [:eviljeff]]

Has anyone actually gotten the submission verifiably to work?  

My attempts result in listings that don't have working images
E.g. https://marketplace-dev.allizom.org/theme/bophutbeach1/ shows http://dev2.addons.phx1.mozilla.com/img/uploads/personas/388169/preview.jpg (outside of a VPN it doesn't resolve; inside it 404's).

Comment 16

[Andrew Williamson [:eviljeff]]

(In reply to Andrew Williamson [:eviljeff] from comment #15)
> Has anyone actually gotten the submission verifiably to work?  
> 
> My attempts result in listings that don't have working images
> E.g. https://marketplace-dev.allizom.org/theme/bophutbeach1/ shows
> http://dev2.addons.phx1.mozilla.com/img/uploads/personas/388169/preview.jpg
> (outside of a VPN it doesn't resolve; inside it 404's).

filed as Bug 795966