Closed Bug 771954 Opened 8 years ago Closed 8 years ago

Rename the shell feed service

Categories

(SeaMonkey :: OS Integration, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file)

We created the separate shell feed service because the wallpaper code had no way of determining whether the shell service supported wallpaper. As of bug 771941 this is no longer a problem and we can simply use the shell service throughout. Note that users of the shell service need to expect its methods to throw.
> Note that users of the shell service need to expect its methods to throw.
The Firefox version doesn't throw. Why do we need to throw?
(In reply to Philip Chee from comment #1)
> > Note that users of the shell service need to expect its methods to throw.
> The Firefox version doesn't throw. Why do we need to throw?
The Windows shell service is our only complete implementation. The Mac shell service implements two methods, and the Linux shell service only one. We could relax that requirement once the shell service implementations are complete.
Attached patch Proposed patchSplinter Review
For the default client dialog I wanted to make it possible for different platforms to implement only some of the possible default options. (I tested this by making the Windows shell service throw for RSS.)

For navigator preferences I wanted to delay showing the default browser group in case we don't support setting as default browser on that platform.

For mailnews I again wanted to support platforms that didn't necessarily implement setting as any of the possible mail options. However the feed button id didn't match the internal constant name so I decided to rename it.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #640436 - Flags: review?(iann_bugzilla)
Comment on attachment 640436 [details] [diff] [review]
Proposed patch

I cannot test on all platforms, but those changes for non-linux look correct.
r=me
Attachment #640436 - Flags: review?(iann_bugzilla) → review+
Pushed comm-central changeset 24962325fc6e.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.