Closed Bug 771968 Opened 10 years ago Closed 10 years ago

onLoginFinish is not defined (in gSyncUI.onStartupComplete)

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: Unfocused, Assigned: gps)

Details

Attachments

(1 file)

In browser-syncui.js, gSyncUI.onSetupComplete tries to call onLoginFinish() - presumably that's meant to be this.onLoginFinish().

Hit this when setting up Sync on a new install. The Sync progress in-content UI showed, but there was no tab for it in the tab strip. Thus I checked the Error Console, and saw the exception - it's the only relevant exception there, so I assume that's what caused the tab to not be added to the tabstrip
OS: Windows 7 → All
Hardware: x86_64 → All
Trivial patch. Verified sync sign-up works after applying. Not totally sure what unintended side-effects could be. Basically this calls updateUI() where it didn't before.
Assignee: nobody → gps
Status: NEW → ASSIGNED
Attachment #640278 - Flags: review?(rnewman)
Attachment #640278 - Flags: review?(rnewman) → review+
looks good with services central build of 1342246581
Whiteboard: [fixed in services] → [verified in services]
https://hg.mozilla.org/mozilla-central/rev/4a46b155c365
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [verified in services]
Target Milestone: --- → mozilla16
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.