If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Status

NSS
Libraries
P1
normal
VERIFIED FIXED
17 years ago
16 years ago

People

(Reporter: jhp (no longer active), Assigned: Wan-Teh Chang)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(6 attachments)

(Reporter)

Description

17 years ago
Building latest NSS code under OS/2.  This is in relation to the NSS 
code that is checked out when doing "make -f client.mk 
BUILD_MODULES=psm2".
(Reporter)

Comment 1

17 years ago
Created attachment 31856 [details] [diff] [review]
Patch for security/nss and security/coreconf
(Reporter)

Updated

17 years ago
Blocks: 72693
(Reporter)

Comment 2

17 years ago
This bug depends on prtypes.h change in bug 76896
Depends on: 76896
(Reporter)

Comment 3

17 years ago
Created attachment 32298 [details] [diff] [review]
new patch with EMX changes

Comment 4

17 years ago
Javier, what branch(es) are these targeted for?

bob
(Reporter)

Comment 5

17 years ago
This is based on what gets checked out when passing 
"BUILD_MODULES=psm2" to client.mk.  This is to get PSM 2 building on 
OS/2 between now and the time NSS autoconf goes in (bug 74459).  If 
the autoconf stuff is going in very soon, then this bug can probably 
be ignored.
(Assignee)

Comment 6

17 years ago
Assigned the bug to wtc.
Assignee: relyea → wtc

Comment 7

17 years ago
Created attachment 33757 [details] [diff] [review]
Optimization fix

Comment 8

17 years ago
Two things

1. After discussing with wtc, we've decided that the DECL 
thing is deprecated. Everything that is NSS_CALLBACK_DECL 
should just be NSS_CALLBACK, and we don't need 
NSS_CALLBACK_DECL in the headers.

2. I put in a change to OS2.mk that fixes an optimization 
issue.
(Assignee)

Comment 9

17 years ago
Is the change to mozilla/security/coreconf/arch.mk (setting
OS_RELEASE to null for OS/2) necessary?

Why are you replacing
    ifdef XP_OS2_VACPP
with
    ifeq ($(OS_ARCH)$(CC),OS2icc)
?

In mozilla/security/coreconf/rules.mk, do you really need to
add $(OS_LIBS) to the $(MKSHLIB) command line?

Comment 10

17 years ago
> Is the change to mozilla/security/coreconf/arch.mk (setting
> OS_RELEASE to null for OS/2) necessary?

I don't believe so.

> Why are you replacing
>     ifdef XP_OS2_VACPP
> with
>     ifeq ($(OS_ARCH)$(CC),OS2icc)
> ?

ifdef XP_OS2_VACPP is kind of a bad thing that isn't even set in security 
configure.in. Basically in our build we need to identify two different 
compilers. After discussion, we decided that the best way to distinguish using 
already set values in configure.in is to use this OS_ARCH/CC mechanism.

> In mozilla/security/coreconf/rules.mk, do you really need to
> add $(OS_LIBS) to the $(MKSHLIB) command line?

I believe you are correct. This isn't needed. OS_LIBS is not set for OS/2.

I will build with these changes to verify.
(Assignee)

Comment 11

17 years ago
Created attachment 35462 [details] [diff] [review]
The combined patch that I will be checking in.
(Assignee)

Comment 12

17 years ago
Created attachment 35470 [details] [diff] [review]
Same patch as above, but applied against the trunk of NSS.
(Assignee)

Comment 13

17 years ago
OK, I've checked in my patch on the NSS_3_2_BRANCH and the
trunk of NSS.  I will need to wait until the Mozilla tree
re-opens to move the NSS_CLIENT_TAG on the modified files.
Until NSS_CLIENT_TAG is updated, you can test by modifying
mozilla/client.mk to pull NSS with the NSS_3_2_BRANCH tag.
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → 3.2.2
Version: unspecified → 3.2.1
(Assignee)

Comment 14

17 years ago
The Mozilla tree is open.  NSS_CLIENT_TAG is updated.  Marked
the bug fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Assignee)

Comment 15

17 years ago
Created attachment 35665 [details] [diff] [review]
Another patch received from Javier Pedemonte.  More PR_CALLBACK's.
(Assignee)

Comment 16

17 years ago
Checked in Javier's latest patch (id=35665) on the NSS_3_2_BRANCH and
the trunk of NSS.  Updated the NSS_CLIENT_TAG on the two modified files.
(Reporter)

Comment 17

17 years ago
verified
Status: RESOLVED → VERIFIED
(Assignee)

Updated

16 years ago
Component: Libraries → Build
(Assignee)

Comment 18

16 years ago
The fix for this bug is not in 3.2.2 but is in 3.3 as well
as on the 3.2 branch.  Since we are not planning to make
any new 3.2.x releases, I am setting the target milestone
to 3.3.
Component: Build → Libraries
Target Milestone: 3.2.2 → 3.3
You need to log in before you can comment on or make changes to this bug.