Closed Bug 772000 Opened 8 years ago Closed 6 years ago

Multiple access keys used in preferences dialog for ca locale

Categories

(Mozilla Localizations :: ca / Catalan, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: whimboo, Assigned: egamonal)

References

()

Details

(Whiteboard: [mozmill-l10n])

Attachments

(1 file)

Attached file screenshots
Our Mozmill l10n tests have been shown that there are some access keys which are used multiple times in the same scope. The full list of those keys you can find here:

http://mozmill-ci.blargon7.com/#/l10n/report/e2b510e5d4ce4614a48bf3e6fb1699ca

Details:

 accessKey: "a" found in: button#useBookmark, radio#alwaysAsk
accessKey: "f" found in: checkbox#rememberForms, label#keepUntil
accessKey: "d" found in: checkbox#blockAutoRefresh, button#setDefaultButton
accessKey: "r" found in: checkbox#searchStartTyping, checkbox#submitTelemetryBox
accessKey: "n" found in: button#clearCacheButton, button#clearOfflineAppCacheButton
accessKey: "a" found in: radio[label=Instal·la les actualitzacions automàticament (és l'opció recomanada per seguretat)], checkbox#warnIncompatible
Assignee: toniher → egamonal
it should work now but I couldn't run the test myself.

http://hg.mozilla.org/releases/l10n/mozilla-aurora/ca/rev/d7e3d2eba17d
Don't worry about the testing part. You can always find the results a couple minutes after the checkin on the following page:

http://mozmill-ci.blargon7.com/#/l10n/reports

As it can be seen for the ca results there is still one issue left:
http://mozmill-ci.blargon7.com/#/l10n/report/23d8fbdd0190d4b0496d6b129f7c82f0

accessKey: "a" found in: button#useBookmark, radio#alwaysAsk
uhms, that's confusing.

according to http://mozmill-ci.blargon7.com/#/l10n/reports?branch=All&platform=All&from=2013-01-01&to=2013-01-20 it's fixed in aurora 20.0a2. the test failed on January 6 for firefox 19.0a2. 

it was also fixed in Beta files: 
http://hg.mozilla.org/releases/l10n/mozilla-beta/ca/file/3dbaa6ad48c4/browser/chrome/browser/preferences/advanced.dtd line 73.

diff http://hg.mozilla.org/releases/l10n/mozilla-beta/ca/rev/d7e3d2eba17d lines 80:81

I just downloaded firefox beta 19.0. I can't see the changes in the binary.
in Preferences > Advanced > Updates (Actualització) both the first radio button and the first child checkbox have accesskey A. The file with those strings and accesskeys defines i as accesskey for the first radio button. 

maybe my changes weren't submitted in time? in any case, I can't see why it only finds an error with A instead of all the others. I changed all the accesskeys in a single transaction to fix this bug.
I would say please re-check whenever you check-in something next in the aurora repository. All the changes you have made should be taken care of in the above mentioned testrun.
Cleaning up old bugs. The access keys are fixed now (checked in Firefox 26)
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
It is indeed. Thank you Jordi.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.