Closed Bug 772005 Opened 10 years ago Closed 10 years ago

Further improve notification of new chat messages

Categories

(Thunderbird :: Instant Messaging, defect)

x86_64
All
defect
Not set
normal

Tracking

(thunderbird15 fixed, thunderbird16 fixed)

RESOLVED FIXED
Thunderbird 17.0
Tracking Status
thunderbird15 --- fixed
thunderbird16 --- fixed

People

(Reporter: andreasn, Assigned: Paenglab)

Details

Attachments

(6 files, 2 obsolete files)

In bug #748358 we stopped opening a new tab and changed the icon when there were new unread chat messages.
JB suggested that we should try and do something more than just change the color (Win/Mac, Linux use a flare) to grab your attention. It would also be good to allow you to see the number of unread messages.
It's quite common to use a blinking icon in IM clients, so I would suggest to try that.
Mockup of animation
Attached image message counter
counter proposal (mac)
Blake - what are your thoughts on these?  My feeling is that the pulsing could get a bit irritating, and I'd go for the badge if possible...
Yep, exactly that.
Assignee: nobody → mconley
Attached patch WIP Patch 1 (obsolete) — Splinter Review
First crack at this - I had to add a new XBL binding for a special toolbarbutton that has a "badge" element. I couldn't just toss a label inside a toolbarbutton, otherwise the icon / label would go away. :/

Positioning the badge is a little tricky, and I'm going to see if I can get Paenglab's help on this too.

Failing that, we can embed a badge into the unreadMessage icon, just without a count.
Paenglab:

Hey - would you have some time to help me out here too? I'm trying to position the red badge overtop of the Chat button icon, but it's rather tricky...hovering over the icon often causes the badge to move around, which is strange.

-Mike
Attached patch WIP patch 2 (obsolete) — Splinter Review
What about this?

The badge is also shown in text only mode. Maybe it should be then different styled because the user don't want icons and the badge should look more like a text element.

What I saw during testing is when changing the button mode (text, icon only, text beside etc.) the badge value is deleted. This isn't important because it's unlikely someone plays a lot with the mode. But maybe it's a bug?
Attachment #644429 - Attachment is obsolete: true
When are a lot of unread messages, everything after the badge is shifted to the right. I think it's okay like this because overlapping other elements shouldn't happen, especially in icon only mode it would then overlap the next button.
Richard:

This looks *awesome*, thank you so much. Just one issue - when in text-only mode for the toolbar, the badge hovers over top of the text, and causes a rather strange appearance. See my attachment.

With that fixed, I think it'll be ready for review.

-Mike
Attached patch PatchSplinter Review
(In reply to Mike Conley (:mconley) from comment #10)
> This looks *awesome*, thank you so much. Just one issue - when in text-only
> mode for the toolbar, the badge hovers over top of the text, and causes a
> rather strange appearance. See my attachment.

You tried before the icon and text mode, didn't you? When you select then text only then the box-orient is vertical. I added a -moz-box-orient: horizontal; when in text mode to force the badge to be on the side.

> With that fixed, I think it'll be ready for review.

Okay, here it is.
Attachment #644628 - Attachment is obsolete: true
Attachment #644962 - Flags: ui-review?(bwinton)
Attachment #644962 - Flags: review?(mconley)
Comment on attachment 644962 [details] [diff] [review]
Patch

Nice!  ui-r=me!
Attachment #644962 - Flags: ui-review?(bwinton) → ui-review+
Comment on attachment 644962 [details] [diff] [review]
Patch

Code looks good - let's roll with this.

Thanks so much Richard - this is fantastic work!
Attachment #644962 - Flags: review?(mconley) → review+
OS: Linux → All
Attachment #644962 - Flags: approval-comm-beta?
Attachment #644962 - Flags: approval-comm-aurora?
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/3f7c3f228397
Assignee: mconley → richard.marti
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
Comment on attachment 644962 [details] [diff] [review]
Patch

This seems like something we want for the initial IM release.
Attachment #644962 - Flags: approval-comm-beta?
Attachment #644962 - Flags: approval-comm-beta+
Attachment #644962 - Flags: approval-comm-aurora?
Attachment #644962 - Flags: approval-comm-aurora+
On my Macbook Air 13", the red badge looks a little bit pixelated and oval (i.s.o round). See attached picture.
Comment on attachment 647517 [details]
Pixelated & oval badge (MacBook Air 13")

For reference, here's the notification on Things, a native Mac app: http://dl.dropbox.com/u/2301433/Screenshots/redOval.png
Seems pretty oval to me, so I think our shape is okay.  I'm not sure what to do to make it smoother.  Perhaps we just live with it, since the number inside isn't the important thing, but rather the existence (or not) of the red button is.
I have a hard time understanding the behavior and meaning of the different signals. I am under the assumption that
- a blue envelope means 'there are new chat messages'
- a red badge means 'your name, or a tracked keyword (Twitter) is contained in one of the new chat messages', or 'you have a direct message'.

The behavior I see does not correspond to this description. Please see  http://imgur.com/a/DMf8T for a screen shot of the toolbar notification and Chat panel report.
(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #19)
> Comment on attachment 647517 [details]
> Pixelated & oval badge (MacBook Air 13")
> 
> For reference, here's the notification on Things, a native Mac app:
> http://dl.dropbox.com/u/2301433/Screenshots/redOval.png
> Seems pretty oval to me, so I think our shape is okay. 
Your oval is larger than tall. Mine is the opposite. My personal taste goes to your layout, but this maybe just my own taste...
As this bug seems general enough, I'd like to propose to send desktop notification when the status is 'Available' and Thunderbird is not focused. This is quite usual with IM application to notify new message on arrival (sender & message) 
I think that with empathy/gnome3, the notification can be used to answer without going to the app - but that's overkill IMHO.

what do you think? should I open a seperated bug?
You need to log in before you can comment on or make changes to this bug.