772022 - Unit test failure: Promise takes the reject path for all chained handlers when a promise is rejected

Status: RESOLVED FIXED

(Pancake Graveyard :: Front-end, defect)

Description

[Sam Foster [:sfoster] (he/him)]

Error in assertion: "takes the reject path for all chained handlers when a promise is rejected"
Expected 1 to be 2.
Expected 1 to be 0.

This is a misunderstanding in the spec - it should be changed to assert the actual behavior. But, we should also make sure we're not making the same assumption in our code.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Test updated to expect actual behavior of our promise lib: 
https://bitbucket.org/mozillapancake/pancake/changeset/8af58298a24d

for the record, I think this behavior is wrong/bad. It should be enough to return an Error instance. Ideally it should be easier to cause a chain of promise handlers to take the rejection path (which neednt signify an error, it more like async if/else)