Unit test failure: Browsing

RESOLVED FIXED in M3

Status

Pancake
Front-end
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: sfoster, Unassigned)

Tracking

unspecified
x86
Mac OS X

Details

(Reporter)

Description

6 years ago
Errors in assertions: 

causes the correct ajax request when a site model is passed to registerHistory
[object Object] in http://colin.local:6543/js/lib/browsing.js?v=1.1 (line 171)

runcauses the correct ajax request when a dictionary is passed to registerHistory
[object Object] in http://colin.local:6543/js/lib/browsing.js?v=1.1 (line 171)

runtracks previous visit for the session
[object Object] in http://colin.local:6543/js/lib/browsing.js?v=1.1 (line 171)

This tests code dating back to around the transition to Backbone.js and all the rewriting that took place since. If these APIs are no longer used they should be removed (and ideally replaced with tests for those that are). Or, they need fixing to test and pass for the current  behaviour.
(Reporter)

Updated

6 years ago
Target Milestone: --- → M3
(Reporter)

Comment 1

6 years ago
All test errors, fixed in: https://bitbucket.org/mozillapancake/pancake/changeset/98d73dfd2464
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.