Closed Bug 772077 Opened 11 years ago Closed 11 years ago

[BrowserAPI] Fix test_browserElement_inproc_ContextmenuEvents.html so it doesn't do SimpleTest.finish() twice

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla16

People

(Reporter: justin.lebar+bug, Unassigned)

References

Details

Attachments

(1 file)

Patch v1
1.21 KB, patch
daleharvey
: review+
daleharvey
: review+
Details | Diff | Splinter Review 
The context menu test registers an onerror handler and calls SimpleTest.finish() off that handler.

It seems that we sometimes get two error events instead of one.  We end up calling finish() twice, which causes an error in the /next/ test.

That we're getting two errors doesn't seem particularly notable to me (I didn't investigate why); this change fixes things by ignoring all but the first error.  We can do a follow-up to see why we're getting two errors, if we think that might be indicative of a problem.
Attached patch Patch v1 — — Splinter Review 

        Attachment #640233 -
        Flags: review?

    
  

        Attachment #640233 -
        Flags: review? → review?(dale)

        Attachment #640233 -
        Flags: review+

    
    

    
  
Is that the correct way to r+ a change? happy with this change though, its a safer test, I will investigate why the second error is thrown, I have other contextmenu work to do

    
    

    
  
> Is that the correct way to r+ a change?

Close.  You set the justin.lebar+bug review? to review+.  As is, you still have a pending review.  :)

Thanks for the r+, though!

        Attachment #640233 -
        Flags: review?(dale) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/552418e64261
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16

    
    

    
  
Try run for 726feb8e3105 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=726feb8e3105
Results (out of 72 total builds):
    success: 62
    warnings: 8
    failure: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jlebar@mozilla.com-726feb8e3105
Component: DOM: Mozilla Extensions → DOM
Component: DOM → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.