Closed Bug 772077 Opened 9 years ago Closed 9 years ago
API] Fix test _browser Element _inproc _Contextmenu Events .html so it doesn't do Simple Test .finish() twice
The context menu test registers an onerror handler and calls SimpleTest.finish() off that handler. It seems that we sometimes get two error events instead of one. We end up calling finish() twice, which causes an error in the /next/ test. That we're getting two errors doesn't seem particularly notable to me (I didn't investigate why); this change fixes things by ignoring all but the first error. We can do a follow-up to see why we're getting two errors, if we think that might be indicative of a problem.
Attachment #640233 - Flags: review? → review?(dale)
Is that the correct way to r+ a change? happy with this change though, its a safer test, I will investigate why the second error is thrown, I have other contextmenu work to do
> Is that the correct way to r+ a change? Close. You set the justin.lebar+bug review? to review+. As is, you still have a pending review. :) Thanks for the r+, though!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Try run for 726feb8e3105 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=726feb8e3105 Results (out of 72 total builds): success: 62 warnings: 8 failure: 2 Builds (or logs if builds failed) available at: http://email@example.com
Component: DOM: Mozilla Extensions → DOM
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.