772325 - Launching an installed web app with no FF supported version - dialog is missing a title

Status: RESOLVED FIXED

(Firefox Graveyard :: Web Apps, defect, P3)

Description

[Jason Smith [:jsmith]]

Steps:

1. Install a Nightly build with support for linux web apps
2. Launch it and install a web application
3. Launch and close that web application
4. Uninstall that Nightly build and ensure that no build in the system has support for linux web apps
5. Launch the web application

Expected:

A dialog should appear with a title indicating "No supported firefox version installed"

Actual:

No dialog title is included in the error dialog.

Comment 1

[Marco Castelluccio [:marco]]

Attachment: Patch

This patch adds a title to the dialog window and sets the skip-taskbar-hint to false (so that it's shown in the taskbar).

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 782107 [details] [diff] [review]
Patch

Review of attachment 782107 [details] [diff] [review]:
-----------------------------------------------------------------

Feels more something for Karl to review.

Comment 3

[Karl Tomlinson (:karlt)]

Is this bug about gtk_window_set_title(), which defaults to "" in GtkMessageDialog?

https://developer.gnome.org/gtk2/2.24/GtkWindow.html#gtk-window-set-title

Comment 4

[Marco Castelluccio [:marco]]

(In reply to Karl Tomlinson (:karlt) from comment #3)
> Is this bug about gtk_window_set_title(), which defaults to "" in
> GtkMessageDialog?
> 
> https://developer.gnome.org/gtk2/2.24/GtkWindow.html#gtk-window-set-title

The bug is about improving the message dialog, I think. I thought instead of the title, it'd be better to have a secondary text (like https://developer.gnome.org/gtk2/2.24/messagedialog.png).

Comment 5

[Karl Tomlinson (:karlt)]

The improvement to the message looks fine to me, even if it doesn't address comment 0.

What label does the taskbar show if the window has no title?

Comment 6

[Marco Castelluccio [:marco]]

(In reply to Karl Tomlinson (:karlt) from comment #5)
> The improvement to the message looks fine to me, even if it doesn't address
> comment 0.
> 
> What label does the taskbar show if the window has no title?

Being on Gnome 3 I didn't think about the taskbar :D
So the label is empty. Should we add a title too? Or only a title and no secondary text?

Comment 7

[Karl Tomlinson (:karlt)]

I suspect GtkMessageDialog's default configuration is designed for use as a dialog window that is "transient-for" another window in the application, and so the message dialog doesn't need to appear in the taskbar because the other window is already there.

Here the GtkMessageDialog does not have a parent, and so I agree it should have skip-taskbar-hint unset.

The lack of title in a transient-for window is not much of a problem because the user is not expected to look for the transient-for window.  A window without a parent though I think should have a title to help the user.

Once the window has a title, IMHO there doesn't seem much point repeating the title in the window as well, but I don't feel too strongly about it.

In the commit message, please describe the change being made to the code and perhaps the reason, rather than quoting the bug's title.

Comment 8

[Marco Castelluccio [:marco]]

Attachment: Patch v2

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/1db016470e55

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1db016470e55