77233 - FMM: Freeing mismatched memory in delete(void *) {1 occurrence}

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Chris Waterson]

Purify coughed up this hairball on nsThread.

[E] FMM: Freeing mismatched memory in delete(void *) {1 occurrence}
        Address 0x02bf6850 points into a malloc'd block 
        Location of free attempt
            delete(void *) [dbgdel.cpp:35]
            nsThread::~nsThread(void) [nsThread.cpp:87]
            nsThread::`vector deleting destructor'(UINT) [xpcom.dll]
            nsThread::Release(void) [nsThread.cpp:148]
            nsThread::Shutdown(void) [nsThread.cpp:404]
            NS_ShutdownXPCOM(nsIServiceManager *) [nsXPComInit.cpp:515]
            main           [nsWinMain.cpp:160]
            mainCRTStartup [crtexe.c:338]
        Allocation location
            calloc         [dbgheap.c:445]
            PR_Calloc      [prmem.c:48]
            PR_NewLogModule [prlog.c:299]
            nsThread::nsThread(void) [nsThread.cpp:62]
            nsIThread::GetIThread(PRThread *,nsIThread * *) [nsThread.cpp:360]
            nsIThread::GetCurrent(nsIThread * *) [nsThread.cpp:341]
            nsIThread::SetMainThread(void) [nsThread.cpp:382]
            NS_InitXPCOM2(nsIServiceManager * *,nsIFile
*,nsIDirectoryServiceProvider *) [nsXPComInit.cpp:259]
            NS_InitXPCOM(nsIServiceManager * *,nsIFile *) [nsXPComInit.cpp:244]
            main           [nsWinMain.cpp:152]

Comment 1

[Edward Kandrot]

Attachment: Changes delete to PR_DELETE

Comment 2

[Edward Kandrot]

Can I hear an r=, sr=?

Comment 3

[Brendan Eich [:brendan]]

PR_DELETE sets its macro-parameter to null, so the caller should not.  Other
than that, r/sr=[e-mail].

/be

Comment 4

[Edward Kandrot]

Attachment: Thanks. Removed =NULL. Need r=.

Comment 5

[Chris Waterson]

r=waterson

Comment 6

[Edward Kandrot]

Thanks.  I just checked it in.