Closed Bug 772376 Opened 12 years ago Closed 12 years ago

Test output of GCLI addon command

Categories

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 24

People

(Reporter: miker, Assigned: miker)

References

Details

Attachments

(1 file, 2 obsolete files)

Joe wants us to extract some of the nested functions up a level.
exec: function(args, context) { function foo() { } foo(); } Can be re-written: exec: function(args, context) { this.foo(); }, foo: function() { }
We should also back-fill some unit tests. I've added some which I'll send you.
Summary: Polish needed in GCLI addons command → Polish needed in GCLI addons command and some extra unit tests needed
Attached patch Patch v1 (obsolete) — Splinter Review
I have moved functions back a level where they are not shared. I have also sorted the addon autocomplete list.
Attachment #641453 - Flags: review?(jwalker)
Comment on attachment 641453 [details] [diff] [review] Patch v1 Review of attachment 641453 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. I think we could also add tests that do: >> addon list // check for the default addon >> addon list theme // not there // perhaps repeat this for all the addon types. It's easy cut and paste code anyway >> addon disable Default >> addon list // Can we easily check it's disabled? >> addon enable Default // Can we easily check it's enabled?
Attached patch v2 (obsolete) — Splinter Review
The tests fail because outputMatch cannot be checked when a command is async. Joe said that I should write tests that should work and he will fix the testing framework.
Attachment #641497 - Flags: review?(jwalker)
Created separate bug for async test issues (bug 773313)
For some strange reason I can't r+ v2. However consider it r+ed.
Attachment #641497 - Flags: review?(jwalker) → review+
Attachment #641453 - Flags: review?(jwalker)
Whiteboard: [gclicommands] → [gclicommands][review+]
This is in need of an un-bitrot, and maybe we could convert to helpers.check while we're at it.
New component triage. Filter on "Lobster Thermidor aux crevettes with a Mornay sauce"
Component: Developer Tools → Developer Tools: Graphic Commandline and Toolbar
Most of this has already been tidied / fixed as parts of other bugs. The tests can now check results though so I will add that.
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Whiteboard: [gclicommands][review+] → [gclicommands]
So, we now test the output of the addon command. Try: https://tbpl.mozilla.org/?tree=Try&rev=a7ad1b01aaf6
Attachment #641453 - Attachment is obsolete: true
Attachment #641497 - Attachment is obsolete: true
Attachment #754786 - Flags: review?(jwalker)
Updating bug title
Summary: Polish needed in GCLI addons command and some extra unit tests needed → Test output of GCLI addon command
Whiteboard: [gclicommands] → [gclicommands][has-patch]
Attachment #754786 - Flags: review?(jwalker) → review+
Whiteboard: [gclicommands][has-patch] → [land-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 24
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: