772376 - Test output of GCLI addon command

Status: RESOLVED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Joe wants us to extract some of the nested functions up a level.

Comment 1

[Joe Walker [:jwalker]]

  exec: function(args, context) {
    function foo() {
    }

    foo();
  }

Can be re-written:

  exec: function(args, context) {
    this.foo();
  },
  foo: function() {
  }

Comment 2

[Joe Walker [:jwalker]]

We should also back-fill some unit tests.
I've added some which I'll send you.

Comment 3

[Joe Walker [:jwalker]]

https://hg.mozilla.org/users/jwalker_mozilla.com/gcli-patches/file/tip/addon2-772376.patch

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Patch v1

I have moved functions back a level where they are not shared. I have also sorted the addon autocomplete list.

Comment 5

[Joe Walker [:jwalker]]

Comment on attachment 641453 [details] [diff] [review]
Patch v1

Review of attachment 641453 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I think we could also add tests that do:

>> addon list
  // check for the default addon

>> addon list theme
  // not there
  // perhaps repeat this for all the addon types. It's easy cut and paste code anyway

>> addon disable Default

>> addon list
  // Can we easily check it's disabled?

>> addon enable Default
  // Can we easily check it's enabled?

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: v2

The tests fail because outputMatch cannot be checked when a command is async. Joe said that I should write tests that should work and he will fix the testing framework.

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Created separate bug for async test issues (bug 773313)

Comment 8

[Joe Walker [:jwalker]]

For some strange reason I can't r+ v2. However consider it r+ed.

Comment 9

[Joe Walker [:jwalker]]

This is in need of an un-bitrot, and maybe we could convert to helpers.check while we're at it.

Comment 10

[Joe Walker [:jwalker]]

New component triage. Filter on "Lobster Thermidor aux crevettes with a Mornay sauce"

Comment 11

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Most of this has already been tidied / fixed as parts of other bugs.

The tests can now check results though so I will add that.

Comment 12

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Test addon command output

So, we now test the output of the addon command.

Try:
https://tbpl.mozilla.org/?tree=Try&rev=a7ad1b01aaf6

Comment 13

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Updating bug title

Comment 14

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/16984bcc47ee

Comment 15

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/16984bcc47ee