Closed
Bug 772376
Opened 12 years ago
Closed 12 years ago
Test output of GCLI addon command
Categories
(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)
DevTools Graveyard
Graphic Commandline and Toolbar
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 24
People
(Reporter: miker, Assigned: miker)
References
Details
Attachments
(1 file, 2 obsolete files)
3.60 KB,
patch
|
jwalker
:
review+
|
Details | Diff | Splinter Review |
Joe wants us to extract some of the nested functions up a level.
Comment 1•12 years ago
|
||
exec: function(args, context) {
function foo() {
}
foo();
}
Can be re-written:
exec: function(args, context) {
this.foo();
},
foo: function() {
}
Comment 2•12 years ago
|
||
We should also back-fill some unit tests.
I've added some which I'll send you.
Summary: Polish needed in GCLI addons command → Polish needed in GCLI addons command and some extra unit tests needed
Comment 3•12 years ago
|
||
Assignee | ||
Comment 4•12 years ago
|
||
I have moved functions back a level where they are not shared. I have also sorted the addon autocomplete list.
Attachment #641453 -
Flags: review?(jwalker)
Comment 5•12 years ago
|
||
Comment on attachment 641453 [details] [diff] [review]
Patch v1
Review of attachment 641453 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good. I think we could also add tests that do:
>> addon list
// check for the default addon
>> addon list theme
// not there
// perhaps repeat this for all the addon types. It's easy cut and paste code anyway
>> addon disable Default
>> addon list
// Can we easily check it's disabled?
>> addon enable Default
// Can we easily check it's enabled?
Assignee | ||
Comment 6•12 years ago
|
||
The tests fail because outputMatch cannot be checked when a command is async. Joe said that I should write tests that should work and he will fix the testing framework.
Attachment #641497 -
Flags: review?(jwalker)
Assignee | ||
Comment 7•12 years ago
|
||
Created separate bug for async test issues (bug 773313)
Comment 8•12 years ago
|
||
For some strange reason I can't r+ v2. However consider it r+ed.
Updated•12 years ago
|
Attachment #641497 -
Flags: review?(jwalker) → review+
Updated•12 years ago
|
Attachment #641453 -
Flags: review?(jwalker)
Assignee | ||
Updated•12 years ago
|
Whiteboard: [gclicommands] → [gclicommands][review+]
Comment 9•12 years ago
|
||
This is in need of an un-bitrot, and maybe we could convert to helpers.check while we're at it.
Comment 10•12 years ago
|
||
New component triage. Filter on "Lobster Thermidor aux crevettes with a Mornay sauce"
Component: Developer Tools → Developer Tools: Graphic Commandline and Toolbar
Assignee | ||
Comment 11•12 years ago
|
||
Most of this has already been tidied / fixed as parts of other bugs.
The tests can now check results though so I will add that.
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Whiteboard: [gclicommands][review+] → [gclicommands]
Assignee | ||
Comment 12•12 years ago
|
||
So, we now test the output of the addon command.
Try:
https://tbpl.mozilla.org/?tree=Try&rev=a7ad1b01aaf6
Attachment #641453 -
Attachment is obsolete: true
Attachment #641497 -
Attachment is obsolete: true
Attachment #754786 -
Flags: review?(jwalker)
Assignee | ||
Comment 13•12 years ago
|
||
Updating bug title
Summary: Polish needed in GCLI addons command and some extra unit tests needed → Test output of GCLI addon command
Whiteboard: [gclicommands] → [gclicommands][has-patch]
Updated•12 years ago
|
Attachment #754786 -
Flags: review?(jwalker) → review+
Assignee | ||
Updated•12 years ago
|
Whiteboard: [gclicommands][has-patch] → [land-in-fx-team]
Comment 14•12 years ago
|
||
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 15•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 24
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•6 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•