77252 - use helper class instead of 64-bit ints in bidi layout code

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Erik van der Poel]

We may wish to consider using a helper class instead of NSPR's 64-bit integers
for some of the bidi-related code in layout. I'm attaching Simon Montagu's patch
for this.

Comment 1

[Erik van der Poel]

Attachment: diffs for mozilla/layout/base/src/nsFrameList.cpp

Comment 2

[Frank Tang]

erik resign. reassign all his bug to ftang for now.

Comment 3

[Frank Tang]

r=ftang

Comment 4

[Frank Tang]

blizzard- can you suprereview this one ?

Comment 5

[Frank Tang]

mark as moz0.9.1

Comment 6

[Christopher Blizzard (:blizzard)]

+#define INT32_MIN 0x80000000

Why is 0x80000000 the min as opposed to 0x00000000?  Also, could you use
something other than INT32_MIN?  Use something like FRAME_MIN or FRAME_MAX and
put it before the actual class so it's self-describing?

Also, what is the cost in performance here?  I'm concerned about pushing another
object on the stack in what is a pretty CPU intensive function.

Comment 7

[Simon Montagu :smontagu]

I agree that the minimum for the line could be 0 (or maybe -1 for luck), but
can't a frame have a negative xcoord?

I'll change the #defines as you suggest.

I don't know about the performance question. The change uses three nsFrameOrigin
objects instead of four PRInt64s. Is that a net loss or gain?

Comment 8

[Frank Tang]

remvoe status whiteboard

Comment 9

[Simon Montagu :smontagu]

Attachment: new diffs addressing blizzard's comments

Comment 10

[Frank Tang]

r=ftang
ask for suprreview again

Comment 11

[Christopher Blizzard (:blizzard)]

sr=blizzard

Comment 12

[Frank Tang]

fixed and check in 

Comment 13

[Chris Petersen]

Marking verified per last comments.