772532 - XPIProvider.jsm spews warnings during some xpcshell tests

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Nathan Froyd [:froydnj]]

When running 'make -C toolkit/components/telemetry/tests/ xpcshell-tests', I see:

JS Component Loader: WARNING resource://gre/modules/XPIProvider.jsm -> resource://gre/modules/XPIProviderUtils.js:150
                     test for equality (==) mistyped as assignment (=)?
JS Component Loader: WARNING resource://gre/modules/XPIProvider.jsm -> resource://gre/modules/XPIProviderUtils.js:308
                     redeclaration of function logSQLError
JS Component Loader: WARNING resource://gre/modules/XPIProvider.jsm -> resource://gre/modules/XPIProviderUtils.js:318
                     redeclaration of function asyncErrorLogger
JS Component Loader: WARNING resource://gre/modules/XPIProvider.jsm -> resource://gre/modules/XPIProviderUtils.js:329
                     redeclaration of function executeStatement
JS Component Loader: WARNING resource://gre/modules/XPIProvider.jsm -> resource://gre/modules/XPIProviderUtils.js:347
                     redeclaration of function stepStatement
JS Component Loader: WARNING resource://gre/modules/XPIProvider.jsm -> resource://gre/modules/XPIProviderUtils.js:367
                     redeclaration of function AsyncAddonListCallback
JS Component Loader: WARNING resource://gre/modules/XPIProvider.jsm -> resource://gre/modules/XPIProviderUtils.js:380
                     test for equality (==) mistyped as assignment (=)?
JS Component Loader: WARNING resource://gre/modules/XPIProvider.jsm -> resource://gre/modules/XPIProviderUtils.js:1206
                     test for equality (==) mistyped as assignment (=)?
JS Component Loader: WARNING resource://gre/modules/XPIProvider.jsm -> resource://gre/modules/XPIProviderUtils.js:1257
                     test for equality (==) mistyped as assignment (=)?
JS Component Loader: WARNING resource://gre/modules/XPIProvider.jsm -> resource://gre/modules/XPIProviderUtils.js:1292
                     test for equality (==) mistyped as assignment (=)?
JS Component Loader: WARNING resource://gre/modules/XPIProvider.jsm -> resource://gre/modules/XPIProviderUtils.js:1313
                     test for equality (==) mistyped as assignment (=)?
JS Component Loader: WARNING resource://gre/modules/XPIProvider.jsm -> resource://gre/modules/XPIProviderUtils.js:1624
                     function XPIDB_getAddons does not always return a value

in the test_TelemetryPing.js.log file.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: patch

Not a huge fan of the while() assignment fixes, but the duplicated function deletion is a definite improvement.

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 640726 [details] [diff] [review]
patch

Review of attachment 640726 [details] [diff] [review]:
-----------------------------------------------------------------

Huh, could have sworn I'd removed that duplication in a previous version of the patch that split out XPIProviderUtils.js.

And, hmm yea, I've never really liked using while loops like that anyway... wish aResults were a generator. Still, less noise = good. Thanks :)

Comment 3

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f8a42c0ed58a

(In reply to Blair McBride (:Unfocused) from comment #2)
> And, hmm yea, I've never really liked using while loops like that anyway...
> wish aResults were a generator. Still, less noise = good. Thanks :)

Yeah, a generator would be much nicer here.  Thanks for the review!

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f8a42c0ed58a