772555 - Provide better localization possibilities for strings in Larry/identity popup/pop-up

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, enhancement)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The site identity popup looks currently:

You are connected to
mozilla.org
which is run by
(unbekannt)


I guess the last one is (unknown) on English phones.

There should be a string behind the (unbekannt)/(unknown) because the proper German localization would be:

Sie sind verbunden mit
mozilla.org
welches von
(unbekannt)
betrieben wird.

There should be a comma behind mozilla.org, but that's not that important compared to this one.

Comment 1

[:Margaret Leibovic]

This is the same localization as desktop Firefox. What does the German translation do there?

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

I discovered that later. It emulates two sentences (which look odd because 50% of the space is not used and the "." at the ends of the sentences are missing, letting it look like a poem.

Can you add an empty line below the domain? That would improve the design/ordering in my humble opinion.

Comment 3

[:Margaret Leibovic]

(In reply to Archaeopteryx [:aryx] from comment #2)

> Can you add an empty line below the domain? That would improve the
> design/ordering in my humble opinion.

Yes, we can definitely do that. We can also file a bug to do the same thing on desktop if you think that would make the desktop translation better.

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Identity popup on desktop with and without empty line

I want to get feedback from Pike on this. The string ids would need to change, I know at least one person who tried to create one sentence from the first four lines.

As attachment you find the identity popup with and without new line so everybody can easily understand what I am talking about.

Comment 5

[:Margaret Leibovic]

I'm sorry, I was confused; I thought you wanted to just add an extra empty string to make translation more flexible. We'll need some UX input if we're going to change the layout of the popup. Ian is on vacation for the week, but Stephen should also be involved if we want the mobile and desktop UIs to stay consistent.

Comment 6

[:Margaret Leibovic]

I haven't been working on this. Unassigning.

Comment 7

[Austin King [:ozten]]

Is this still a problem? Please open a new issue at https://github.com/mozilla/browserid/issues/new

Comment 8

[:Margaret Leibovic]

(In reply to Austin King [:ozten] from comment #7)
> Is this still a problem? Please open a new issue at
> https://github.com/mozilla/browserid/issues/new

I'm confused... this bug isn't about browser id.

Comment 9

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.