772587 - [UI] Admin - Set featured versions, ensure error message is not added more than once

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Schalk Neethling [:espressive]]

On branch data sources in the admin section, when setting featured versions, ensure error message is not added more than once.

Comment 1

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/fab0c9ace1570e666a2eec9a30deb4163fd5cbdb
preventing multiple error messages fixes bug 772587

https://github.com/mozilla/socorro/commit/a869373a5cf104b9fc18c1985bbb288f2769bb95
Merge pull request #688 from ossreleasefeed/prevent-repetitive-error-messages-772587

preventing multiple error messages fixes bug 772587

Comment 2

[Schalk Neethling [:espressive]]

Pull request sent and merged https://github.com/mozilla/socorro/pull/688

Comment 3

[Matt Brandt [:mbrandt]]

Thanks Schalk :-) you beat me to this bug.

Comment 4

[Schalk Neethling [:espressive]]

This bug was bigger than the description shows. Once an error was triggered on the client side, the user would no longer be able to submit an update, even if there was no client side error.

The pull request above, also resolves this problem.

Comment 5

[Matt Brandt [:mbrandt]]

Not sure if I'm mistaken and the above pull hasn't landed yet but I'm seeing the below behavior.

On both dev and staging - In the admin UI an administrator can no longer update the featured product on products and instead receive the following error message -

"Each product should have a minimum or one, and a maximum of four featured products. The following products does not meet this criteria, Camino"

Steps to reproduce:
1. login to the admin area - dev and stage envs
2. browse to Branch Data Sources -> Products
3. In the Firefox section: deselect a featured product and select a different one
4. click "Update Featured Versions"

Expected:
The previously featured product is no longer selected and the newly selected one is selected and viewable on in https://crash-stats-dev.allizom.org/products/Firefox and https://crash-stats.allizom.org/products/Firefox

Actual:
The admin user is unable to update the featured products - when attempting to update the featured products an error message is displayed:

"Each product should have a minimum or one, and a maximum of four featured products. The following products does not meet this criteria, Camino"

Screencast:
http://screencast.com/t/oUqMmfp9

Comment 6

[Schalk Neethling [:espressive]]

(In reply to Matt Brandt [:mbrandt] from comment #5)

So the problem is happening because on prod Camino has no releases and hence does not conform the the rule of each product have at least one and no more than four featured releases.

The question no becomes, do I tweak my script to accommodate this or, do we change the UI to not show products for which there are no releases.

Comment 7

[Robert Kaiser]

Well, having one product in the set that does not have a release should not break setting featured versions for other products.

Comment 8

[Schalk Neethling [:espressive]]

[:kairo] Ok, so from your comment I take we still display the product even with no releases so, I will tweak my script.

Comment 9

[Matt Brandt [:mbrandt]]

Sckalk - while you're updating the app for the new behavior (comment 7) can you tweak the error message? It's a bit off :-)

"Each product should have a minimum of one and a maximum of four featured products. The following product(s) does not meet this criteria XXX"

Where 'XXX' are the products.

Comment 10

[Schalk Neethling [:espressive]]

Sent pull request to be cherry picked onto stage for verification:
https://github.com/mozilla/socorro/pull/708

Comment 11

[Matt Brandt [:mbrandt]]

(In reply to Schalk Neethling [:espressive] from comment #10)
> Sent pull request to be cherry picked onto stage for verification:
> https://github.com/mozilla/socorro/pull/708

Schalk and rhmeler, thanks for landing pull/708 on stage

Comment 12

[Matt Brandt [:mbrandt]]

QA verified on stage - 
** On branch data sources in the admin section, when setting featured versions, ensure error message is not added more than once. (comment 0)
** The previously featured product is no longer selected and the newly selected one is selected and viewable on in https://crash-stats-dev.allizom.org/products/Firefox and https://crash-stats.allizom.org/products/Firefox (comment 5)
** The ability to add 1 - 4 featured products works correctly
** Error messages are displayed if less than 1 product or greater than 4 products are selected.