772656 - End text selection when switching tabs

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[:Margaret Leibovic]

Attachment: patch

For performance reasons, let's kill the active selection if we switch tabs.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 640810 [details] [diff] [review]
patch


>diff --git a/mobile/android/chrome/content/browser.js b/mobile/android/chrome/content/browser.js

>   uninit: function sh_uninit() {
>     Services.obs.removeObserver(this, "Gesture:SingleTap", false);
>     Services.obs.removeObserver(this, "Window:Resize", false);
>+    Services.obs.removeObserver(this, "Tab:Selected", false);
>     Services.obs.removeObserver(this, "after-viewport-change", false);
>   },

Cleanup: removeObserver does not have a third param. You can remove those.

Comment 2

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cfc62f5ab57d

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cfc62f5ab57d

Comment 4

[:Margaret Leibovic]

Comment on attachment 640810 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): this should be part of the text selection mass uplift (bug 695173), but was fixed after the roll-up patch in that bug was created
User impact if declined: starting text selection on a different tab can be slow
Testing completed (on m-c, etc.): landed on m-c 7/10
Risk to taking this patch (and alternatives if risky): low risk 
String or UUID changes made by this patch: n/a

Comment 5

[:Margaret Leibovic]

Uplifted to aurora as part of a roll-up patch:
https://hg.mozilla.org/releases/mozilla-aurora/rev/2fb0a358eaf6