Closed
Bug 772684
Opened 12 years ago
Closed 12 years ago
ICS on HDPI phone shows ugly tab button, broken design affecting urlbar and menu button
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(firefox15 verified, firefox16 verified, firefox17 verified)
VERIFIED
FIXED
Firefox 16
People
(Reporter: bnicholson, Assigned: sriram)
References
Details
(Keywords: regression)
Attachments
(3 files)
252.32 KB,
image/png
|
Details | |
396.23 KB,
patch
|
mfinkle
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
51.96 KB,
patch
|
mfinkle
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 1•12 years ago
|
||
This is on a Droid RAZR (which has a physical menu button).
Assignee | ||
Comment 2•12 years ago
|
||
This patch (finally!) moves the menu button to the right. If there is a menu button present, a different browser_toolbar_menu is loaded. Note: We need newer resources from Ian for: tabs normal/pressed buttons, tabs normal/pressed buttons with tail, menu buttons, menu normal/pressed state buttons, tab new normal/pressed buttons. Currently mdpi/hdpi + ICS + s/w menu button will have an ugly texture for tabs button.
Attachment #641140 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 3•12 years ago
|
||
I added "drawable-xhdpi-v11" under the impression that xhdpi run only ICS (only Nexus was there then). But, in the future, there is a possibility that xhdpi may run gingerbread. In which case we will fail. Hence I've moved the generic (and gingerbread specific) resources to drawable-xhpi/ and left the honeycomb+ resources in drawable-xhdpi-v11/ Now the contents of these folders look the same like drawable/ and drawable-hdpi/
Attachment #641141 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 4•12 years ago
|
||
(In reply to Sriram Ramasubramanian [:sriram] from comment #3) > Created attachment 641141 [details] [diff] [review] > Patch (2/2): Refactor XHDPI > > I added "drawable-xhdpi-v11" under the impression that xhdpi run only ICS > (only Nexus was there then). > But, in the future, there is a possibility that xhdpi may run gingerbread. > In which case we will fail. > Hence I've moved the generic (and gingerbread specific) resources to > drawable-xhpi/ and left the honeycomb+ resources in drawable-xhdpi-v11/ > Now the contents of these folders look the same like drawable/ and > drawable-hdpi/ Note: We need new "gingerbread" like icons for alert_* and ic_menu_* in drawable-xhdpi/. They are now copied from drawable-xhdpi-v11/ and are honeycomb+ specific.
Updated•12 years ago
|
Summary: ICS on HDPI phone shows ugly tab button → ICS on HDPI phone shows ugly tab button, broken design affecting urlbar and menu button
Comment 5•12 years ago
|
||
Comment on attachment 641140 [details] [diff] [review] Patch Lot's of additions and renames. Make sure all the possibles are tested. Make sure you clobber when landing.
Attachment #641140 -
Flags: review?(mark.finkle) → review+
Updated•12 years ago
|
Attachment #641141 -
Flags: review?(mark.finkle) → review+
Comment 6•12 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #5) > Lot's of additions and renames. Make sure all the possibles are tested. Make > sure you clobber when landing. As a favor to mergers, please include a note in the commit message (like "Android clobber needed") so we know to clobber before landing this on other branches too. Thanks!
Updated•12 years ago
|
Keywords: regression
Assignee | ||
Comment 7•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/7826903ddbf2 http://hg.mozilla.org/integration/mozilla-inbound/rev/82acb91724a1 This needs clobbering.
Comment 8•12 years ago
|
||
Will this resolve the presence of a S/W menu button in the top right-hand corner on the Galaxy S III?
Assignee | ||
Comment 9•12 years ago
|
||
Oh yes! This will fix Galaxy S III -- XHDPI + ICS + h/w menu button.
Comment 10•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7826903ddbf2 https://hg.mozilla.org/mozilla-central/rev/82acb91724a1
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Attachment #641140 -
Flags: approval-mozilla-aurora+
Updated•12 years ago
|
Attachment #641141 -
Flags: approval-mozilla-aurora+
Updated•12 years ago
|
Assignee: nobody → sriram
Comment 13•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/2d9ab7fbd680 https://hg.mozilla.org/releases/mozilla-aurora/rev/479756495eed
status-firefox15:
--- → fixed
status-firefox16:
--- → fixed
Updated•12 years ago
|
Target Milestone: --- → Firefox 16
Updated•12 years ago
|
Status: RESOLVED → VERIFIED
status-firefox17:
--- → verified
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•