Closed Bug 772684 Opened 9 years ago Closed 9 years ago

ICS on HDPI phone shows ugly tab button, broken design affecting urlbar and menu button

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox15 verified, firefox16 verified, firefox17 verified)

VERIFIED FIXED
Firefox 16
Tracking Status
firefox15 --- verified
firefox16 --- verified
firefox17 --- verified

People

(Reporter: bnicholson, Assigned: sriram)

References

Details

(Keywords: regression)

Attachments

(3 files)

Attached image screenshot
No description provided.
This is on a Droid RAZR (which has a physical menu button).
Attached patch PatchSplinter Review
This patch (finally!) moves the menu button to the right. If there is a menu button present, a different browser_toolbar_menu is loaded.

Note: We need newer resources from Ian for:
tabs normal/pressed buttons, tabs normal/pressed buttons with tail, menu buttons, menu normal/pressed state buttons, tab new normal/pressed buttons.

Currently mdpi/hdpi + ICS + s/w menu button will have an ugly texture for tabs button.
Attachment #641140 - Flags: review?(mark.finkle)
I added "drawable-xhdpi-v11" under the impression that xhdpi run only ICS (only Nexus was there then).
But, in the future, there is a possibility that xhdpi may run gingerbread. In which case we will fail.
Hence I've moved the generic (and gingerbread specific) resources to drawable-xhpi/ and left the honeycomb+ resources in drawable-xhdpi-v11/
Now the contents of these folders look the same like drawable/ and drawable-hdpi/
Attachment #641141 - Flags: review?(mark.finkle)
(In reply to Sriram Ramasubramanian [:sriram] from comment #3)
> Created attachment 641141 [details] [diff] [review]
> Patch (2/2): Refactor XHDPI
> 
> I added "drawable-xhdpi-v11" under the impression that xhdpi run only ICS
> (only Nexus was there then).
> But, in the future, there is a possibility that xhdpi may run gingerbread.
> In which case we will fail.
> Hence I've moved the generic (and gingerbread specific) resources to
> drawable-xhpi/ and left the honeycomb+ resources in drawable-xhdpi-v11/
> Now the contents of these folders look the same like drawable/ and
> drawable-hdpi/

Note: We need new "gingerbread" like icons for alert_* and ic_menu_* in drawable-xhdpi/. They are now copied from drawable-xhdpi-v11/ and are honeycomb+ specific.
Summary: ICS on HDPI phone shows ugly tab button → ICS on HDPI phone shows ugly tab button, broken design affecting urlbar and menu button
Comment on attachment 641140 [details] [diff] [review]
Patch

Lot's of additions and renames. Make sure all the possibles are tested. Make sure you clobber when landing.
Attachment #641140 - Flags: review?(mark.finkle) → review+
Attachment #641141 - Flags: review?(mark.finkle) → review+
(In reply to Mark Finkle (:mfinkle) from comment #5)
> Lot's of additions and renames. Make sure all the possibles are tested. Make
> sure you clobber when landing.

As a favor to mergers, please include a note in the commit message (like "Android clobber needed") so we know to clobber before landing this on other branches too.  Thanks!
Blocks: 769237
Keywords: regression
Will this resolve the presence of a S/W menu button in the top right-hand corner on the Galaxy S III?
Oh yes! This will fix Galaxy S III -- XHDPI + ICS + h/w menu button.
Duplicate of this bug: 773550
Duplicate of this bug: 773762
Attachment #641140 - Flags: approval-mozilla-aurora+
Attachment #641141 - Flags: approval-mozilla-aurora+
Assignee: nobody → sriram
Target Milestone: --- → Firefox 16
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.