crash in nsMsgLocalMailFolder::EndMessage

RESOLVED FIXED in Thunderbird 17.0

Status

MailNews Core
Backend
--
critical
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Vincent (caméléon), Assigned: m_kato)

Tracking

({crash, regression})

Thunderbird 17.0
x86
All
crash, regression

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [GS], crash signature, URL)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
This bug was filed from the Socorro interface and is 
report bp-b26ee583-e11d-42d4-8318-03f9a2120704 .
============================================================= 
User report on GetSatisfaction:
"When I try to move emails from from my Inbox, etc. to various local folders...Tbird crashes. Anything over 10-15 emails at a time and I have this problem.

Any ideas why? I am running 13.0.1. PC running Win 7"

Source: https://getsatisfaction.com/mozilla_messaging/topics/thunderbird_crashes_when_trying_to_move_emails_between_folders
(Reporter)

Updated

5 years ago
0 	xul.dll 	nsMsgLocalMailFolder::EndMessage 	mailnews/local/src/nsLocalMailFolder.cpp:2607
1 	xul.dll 	nsCopyMessageStreamListener::EndMessage 	mailnews/base/src/nsCopyMessageStreamListener.cpp:117
2 	xul.dll 	nsImapMailFolder::EndMessage 	mailnews/imap/src/nsImapMailFolder.cpp:5674
3 	xul.dll 	`anonymous namespace'::SyncRunnable2<nsIImapMailFolderSink,nsIMsgMailNewsUrl*,ch 	mailnews/imap/src/nsSyncRunnableHelpers.cpp:178
4 	xul.dll 	nsThread::ProcessNextEvent 	xpcom/threads/nsThread.cpp:657
5 	xul.dll 	NS_ProcessNextEvent_P 	objdir-tb/mozilla/xpcom/build/nsThreadUtils.cpp:245
6 	xul.dll 	mozilla::ipc::MessagePump::Run 	ipc/glue/MessagePump.cpp:134
7 	xul.dll 	MessageLoop::RunInternal 	ipc/chromium/src/base/message_loop.cc:208
8 	xul.dll 	MessageLoop::RunHandler 	ipc/chromium/src/base/message_loop.cc:201
9 	xul.dll 	MessageLoop::Run 	ipc/chromium/src/base/message_loop.cc:175
10 	xul.dll 	nsBaseAppShell::Run 	widget/xpwidgets/nsBaseAppShell.cpp:189
11 	xul.dll 	nsAppShell::Run 	widget/windows/nsAppShell.cpp:252
12 	xul.dll 	nsAppStartup::Run 	toolkit/components/startup/nsAppStartup.cpp:295
13 	xul.dll 	XRE_main 	toolkit/xre/nsAppRunner.cpp:3703
14 	thunderbird.exe 	do_main 	mail/app/nsMailApp.cpp:144
15 	thunderbird.exe 	NS_internal_main 	mail/app/nsMailApp.cpp:233
16 	thunderbird.exe 	wmain 	toolkit/xre/nsWindowsWMain.cpp:107
17 	thunderbird.exe 	__tmainCRTStartup 	crtexe.c:594
18 	kernel32.dll 	BaseThreadInitThunk 	
19 	ntdll.dll 	__RtlUserThreadStart 	
20 	ntdll.dll 	_RtlUserThreadStart
Component: Folder and Message Lists → Backend
Product: Thunderbird → MailNews Core
(Assignee)

Comment 2

5 years ago
seekableStream (and mCopyState->m_fileStream) is null.
(Assignee)

Updated

5 years ago
OS: Windows NT → Windows 7
Makoto-San could you cook up a patch ?
crash begins with version 12 https://crash-stats.mozilla.com/report/list?product=Thunderbird&version=Thunderbird%3A13.0.1&version=Thunderbird%3A12.0&version=Thunderbird%3A11.0.1&version=Thunderbird%3A11.0&version=Thunderbird%3A16.0a1&version=Thunderbird%3A15.0a2&version=Thunderbird%3A15.0a1&version=Thunderbird%3A14.0b4&version=Thunderbird%3A14.0b3&version=Thunderbird%3A14.0b2&version=Thunderbird%3A14.0b1&version=Thunderbird%3A13.0&version=Thunderbird%3A13.0b4&version=Thunderbird%3A13.0b3&version=Thunderbird%3A13.0b2&version=Thunderbird%3A12.0.1&version=Thunderbird%3A10.0.5esr&version=Thunderbird%3A10.0.4esr&query_search=signature&query_type=exact&query=nsMsgLocalMailFolder%3A%3AEndMessage%28unsigned%20int%29&reason_type=contains&date=5%2F11%2F2012%2004%3A19%3A42&range_value=4&range_unit=weeks&hang_type=any&process_type=any&do_query=1&admin=1&signature=nsMsgLocalMailFolder%3A%3AEndMessage%28unsigned%20int%29
Keywords: regression
(Assignee)

Updated

5 years ago
Assignee: nobody → m_kato
(Assignee)

Comment 5

5 years ago
Created attachment 642898 [details] [diff] [review]
possible fix
(Assignee)

Updated

5 years ago
Attachment #642898 - Flags: review?(mozilla)

Comment 6

5 years ago
Comment on attachment 642898 [details] [diff] [review]
possible fix

thx for the patch, you can remove the braces, right?
Attachment #642898 - Flags: review?(mozilla) → review+
regression from bug 675407 ?  But crash didn't start until version 12, and 675407 landed in version 10
Crash Signature: [@ nsMsgLocalMailFolder::EndMessage(unsigned int)] → [@ nsMsgLocalMailFolder::EndMessage(unsigned int)] [@ nsMsgLocalMailFolder::EndMessage]
OS: Windows 7 → All
(Assignee)

Comment 8

5 years ago
(In reply to Wayne Mery (:wsmwk) from comment #7)
> regression from bug 675407 ?  But crash didn't start until version 12, and
> 675407 landed in version 10

No, I think that this is regression by bug 402392.
(Assignee)

Comment 9

5 years ago
http://hg.mozilla.org/comm-central/rev/d0c32b433cea
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
Thanks Makoto-San

posted info in gsfn topic
Blocks: 402392
You need to log in before you can comment on or make changes to this bug.