77277 - Trunk crash [@ nsCookieService::SetCookieStringFromHttp ] reading a message

Status: VERIFIED FIXED

(Core :: Networking: Cookies, defect)

Description

[scottputterman]

using the 4/23 build a number of us crash reading a message with the stack at 
the end of this comment.  I can't put the message in this bug.  bienvenu says 
the fix is to fix setCookie to check for a null aFirstUrl like you did for 
getCookie. See http://bugzilla.mozilla.org/show_bug.cgi?id=75948.

nsCookieService::SetCookieStringFromHttp 
[d:\builds\seamonkey\mozilla\extensions\cookie\nsCookieService.cpp, line 170] 
nsCookieHTTPNotify::AsyncExamineResponse 
[d:\builds\seamonkey\mozilla\extensions\cookie\nsCookieHTTPNotify.cpp, line 
261] 
XPTC_InvokeByIndex 
[d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcinvoke.cpp, 
line 139] 
EventHandler [d:\builds\seamonkey\mozilla\xpcom\proxy\src\nsProxyEvent.cpp, 
line 510] 
nsProxyObject::Post 
[d:\builds\seamonkey\mozilla\xpcom\proxy\src\nsProxyEvent.cpp, line 450] 
nsProxyEventObject::CallMethod 
[d:\builds\seamonkey\mozilla\xpcom\proxy\src\nsProxyEventObject.cpp, line 465] 
PrepareAndDispatch 
[d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcstubs.cpp, 
line 102] 
SharedStub 
[d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcstubs.cpp, 
line 124] 
nsHTTPChannel::OnHeadersAvailable 
[d:\builds\seamonkey\mozilla\netwerk\protocol\http\src\nsHTTPChannel.cpp, line 
2465] 
nsHTTPChannel::FinishedResponseHeaders 
[d:\builds\seamonkey\mozilla\netwerk\protocol\http\src\nsHTTPChannel.cpp, line 
2742] 
nsHTTPServerListener::FinishedResponseHeaders 
[d:\builds\seamonkey\mozilla\netwerk\protocol\http\src\nsHTTPResponseListener.c
pp, line 1028] 
nsHTTPServerListener::OnDataAvailable 
[d:\builds\seamonkey\mozilla\netwerk\protocol\http\src\nsHTTPResponseListener.c
pp, line 416] 
nsOnDataAvailableEvent::HandleEvent 
[d:\builds\seamonkey\mozilla\netwerk\base\src\nsStreamListenerProxy.cpp, line 
183] 
PL_HandleEvent [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 589] 
PL_ProcessPendingEvents [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, 
line 522] 
_md_EventReceiverProc [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, 
line 1070] 
nsAppShellService::Run 
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsAppShellService.cpp, line 408] 
netscp6.exe + 0x16ec (0x004016ec) 
netscp6.exe + 0x11b8 (0x004011b8) 
netscp6.exe + 0x2b92 (0x00402b92) 
KERNEL32.DLL + 0x192a6 (0x77e992a6)

Comment 1

[scottputterman]

Nominating for beta1 and making a high severity since reading a message 
shouldn't crash.

Comment 2

[(not reading, please use [e-mail] instead)]

I'm unable to reproduce outside the firewall, but I can inside.
(outside, I timeout on the message)

I can help debug / work up a fix for this tomorrow.

Comment 3

[esther]

*** Bug 77363 has been marked as a duplicate of this bug. ***

Comment 4

[esther]

Jeremy sent me the original message and I saved (witn 4.7) the attached html 
that is in the crashing msg to my desktop. The html opened OK, but when I 
selected Edit Page I crashed (this is using 6.5).
 

Comment 5

[(not reading, please use [e-mail] instead)]

here a fix.  morse, please review or comment.

Comment 6

[(not reading, please use [e-mail] instead)]

Attachment: patch, please review. asserts

Comment 7

[(not reading, please use [e-mail] instead)]

that patch fixes the crash, but there are still plenty of asserts (caused by 
the relative <img src> tags in the message).  

but those are known and covered in other bugs.

Comment 8

[Stephen P. Morse]

Patch looks fine to me.  Thanks for taking this one.

r=morse

Comment 9

[(not reading, please use [e-mail] instead)]

thanks for the quick review.

taking.

Comment 10

[David :Bienvenu]

sr=bienvenu

Comment 11

[(not reading, please use [e-mail] instead)]

accepting.

Comment 12

[(not reading, please use [e-mail] instead)]

moving to 0.9, simple crasher fix.

I'll go get some [e-mail] approval.

Comment 13

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to 0.9

Comment 14

[(not reading, please use [e-mail] instead)]

fixed.

Comment 15

[Stephen P. Morse]

*** Bug 77434 has been marked as a duplicate of this bug. ***

Comment 16

[greer]

Adding the stacksig in summary field for talkback tracking of the fixed bug in 
future builds.

Comment 17

[Tom Everingham]

verified