772835 - change get_window and get_windows to match Selenium

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[David Burns :automatedtester]

These need to be updated to match the Selenium API to allow easy swapping in

Comment 1

[David Burns :automatedtester]

Attachment: removing get_window

If there are tests outside of the marionette repo that need updating let me know

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 641166 [details] [diff] [review]
removing get_window

Review of attachment 641166 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but it looks like you deleted a line by accident.  r+ with that fixed.

::: testing/marionette/client/marionette/tests/unit/test_getattr.py
@@ -30,5 @@
>          MarionetteTestCase.tearDown(self)
>  
>      def test_getAttribute(self):
>          el = self.marionette.execute_script("return window.document.getElementById('textInput');")
> -        found_el = self.marionette.find_element("id", "textInput")

Was this line deleted by mistake?

Comment 3

[David Burns :automatedtester]

That line is not supposed to be there, it was a copy paste error when the test was originally created. I spoke to :mdas about it on IRC

http://logbot.glob.com.au/?c=mozilla%23ateam&s=11+Jul+2012&e=11+Jul+2012&b=1#c372310

If you want me to do this in a separate bug let me know. I appreciate it is not part of the work I am doing

Comment 4

[Jonathan Griffin (:jgriffin)]

No worries, if it's ok to remove it, I'm ok with it being in this patch.

Comment 5

[David Burns :automatedtester]

landed in https://hg.mozilla.org/integration/mozilla-inbound/rev/f25cba119ef9

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f25cba119ef9