77285 - Modern-only: Yellow smiley face missing in Preferences

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect)

Description

[Seak, Teng-Fong]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.8.1+)
Gecko/20010423
BuildID:    20010423

Just a cosmetic problem: the yellow smiley face is missing in on of the
preferences windows.


Reproducible: Always
Steps to Reproduce:
1.Preferences > Mail and Newsgroup > Message display
2.There's the option "Display emoticons as graphics."


Actual Results:  "For example, display ':-)' as ."

Expected Results:  A yellow smiley face after the word "as".

Comment 1

[sairuh (rarely reading bugmail)]

are you using the modern theme? this is a dupe, but i cannot seem to find the
original bug. nbaca/pmac, d'you know the bug number? thx!

Comment 2

[Seak, Teng-Fong]

Yes, I'm using modern theme.  Strange that the same problem doesn't exist in
classic theme.  In Netscape6 the problem doesn't happen in either theme. They've
probably fixed the bug.  Shouldn't they feedback bug corrections to Mozilla
project team?

Comment 3

[Stephen Walker]

*** Bug 78132 has been marked as a duplicate of this bug. ***

Comment 4

[Ninoschka Baca]

I know this is a duplicate but I'm also having problems finding the original bug.
I'll continue to look for the original bug.

Build 2001-04-30-08, 2001-05-01-04: Mac 9.04
Build 2001-04-30-04: WinME
I see the smiley using the Classic theme but not with the Modern. 

Comment 5

[Chris McAfee]

verified on w2k, current build, modern.

Comment 6

[sairuh (rarely reading bugmail)]

cc'ing blake and hewitt, in case they know where that original bug is. :)

Comment 7

[Blake Ross]

Bug 58747?

Comment 8

[Ninoschka Baca]

Build 2001-05-02-04: WinMe
Build 2001-05-02-08: Mac 9.04
Using modern I still don't see the smiley. Will I see it with a 5/3 build?

Comment 9

[Ken Snider]

bug 58747 was the same problem on the classic skin. Interestingly at the time
the modern theme *worked* properly, so this appears to be a regression.

either way, changing the component to "Themes" as per 58747

Comment 10

[Stephen Walker]

Attachment: patch

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

sr=[e-mail]. Ideally these images would move to communicator/skin
somewhere. 

Comment 12

[Chris McAfee]

going with walker's patch for now, not sure that pointing
at editor icons is that bad an option.  I initially liked
the communicator/skin idea, but ? I've changed my mind
and maybe editor is ok here.  Fixed.

Comment 13

[Ninoschka Baca]

Branch Build 2001-07-02-03: WinMe, Mac 9.04
Branch Build 2001-07-02-06: Linux RH 6.2
Verified Fixed. Smiley present for modern and classic.

Comment 14

[石庭豐 (Seak, Teng-Fong)]

I'm the original reporter. I'm now using 20010925 and the bug comes back!
Someone using a more recent built has this bug in modern theme?

Comment 15

[Chris McAfee]

reopening

Comment 16

[Chris McAfee]

over to pchen.  regression

Comment 17

[sairuh (rarely reading bugmail)]

->default themes owners

Comment 18

[Malcolm Rowe]

I think this regression (occurring in both Modern and Classic) has been opened 
as bug 101647.

Comment 19

[Joe Hewitt (gone)]

--> shliang

Comment 20

[shliang]

Attachment: patch

Comment 21

[Jason A.]

On Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.5+) Gecko/20011111,

Modern theme has no problems. The smiley appears every time.

OTOH, the smiley icon is always invisible when using the Classic theme.

Comment 22

[石庭豐 (Seak, Teng-Fong)]

Original reporter's here!
Very funny! Before, it was in Modern theme that the yellow smiley didn't appear,
now, in my 1109 built, indeed, it's in Classic theme that the smiley is absent!
My "Airpilot" theme no longer works for this built, and it seems like our theme
page is no longer available in theme.org, so I can't check with other themes.

Comment 23

[shliang]

Attachment: fixing in classic

Comment 24

[Joe Hewitt (gone)]

Comment on attachment 57615 [details] [diff] [review]
fixing in classic

sr=hewitt

Comment 25

[andreww]

Comment on attachment 57615 [details] [diff] [review]
fixing in classic

r=andreww

Comment 26

[[not reading bugmail]]

its also a problem in classic theme too btw. W2K 11-26 nightly.

Comment 27

[shliang]

checked in

Comment 28

[Patty Mac]

Verified on windows and linux (2001-11-29-09-trunk)

Comment 29

[sairuh (rarely reading bugmail)]

dennis, i recall seeing the missing graphical smiley in the classic theme, too,
but it was on a linux mozilla build from 11/26.

i cannot grab a recent linux mozilla build, since the installer is currently
busted there. however, mozilla bits from today on mac 10.1.1 and winNT look fine
to me. moreover, the commercial builds [from 2001.11.28.0x] all look fine, on
all platforms, both themes.