772853 - upgrade clang to r160176

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: update the clang manifest. To be committed after try is done.

Opening the bug in releng. Let me know it should use some other component now that we have tooltool.

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

for the record, this is what I did (I will cleanup the scripts and put the in m-c at some point):

--------------------------------
$ cat ~/mozilla/create-manifest.sh
#!/bin/sh

set -e
rm -f *.manifest tooltool.py setup.sh

curl -O https://raw.github.com/jhford/tooltool/master/tooltool.py
curl -O https://hg.mozilla.org/mozilla-central/raw-file/tip/build/unix/build-clang/setup.sh
python tooltool.py -m linux32.manifest add clang-linux32.tar.bz2 setup.sh
python tooltool.py -m linux64.manifest add clang-linux64.tar.bz2 setup.sh
python tooltool.py -m darwin.manifest add clang-darwin.tar.bz2 setup.sh
sed -i 's/clang-.*.tar.bz2/clang.tar.bz2/g' *.manifest

python ~/mozilla/create-manifest-aux.py
$ cat ~/mozilla/create-manifest-aux.py
#!/bin/python

import os

for platform in ['darwin', 'linux32', 'linux64']:
    old_name = 'clang-' + platform + '.tar.bz2'
    manifest = platform + '.manifest'
    new_name = eval(file(manifest).read())[1]['digest']
    os.rename(old_name, new_name)

--------------------------

Run the script, copy the manifest to an m-c tree, edit to add the clang version. And then copy the files to the server:
$ ssh [e-mail] -L 1500:relengweb1.dmz.scl3.mozilla.com:22
and in another terminal
scp -P 1500 * respindola@localhost:/var/www/html/runtime-binaries/tooltool/sha512/

Comment 2

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: update the build script

Testing on try found an issue with r160034, which I fixed in 160105.

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://hg.mozilla.org/mozilla-central/rev/b24995e163b5

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: clang manifest update

To be committed after a try run. I updated the scripts a bit (almost good enough for code review :-) ), which is why the indentation changed a bit:

cat ~/mozilla/create-manifest-aux.py
#!/bin/python

import os
import simplejson
import sys

def key_sort(item):
    item = item[0]
    if item == 'size':
        return 0
    if item == 'digest':
        return 1
    if item == 'algorithm':
        return 3
    return 4

rev = os.path.basename(os.getcwd()).split('-')[1]

for platform in ['darwin', 'linux32', 'linux64']:
    old_name = 'clang-' + platform + '.tar.bz2'
    manifest = platform + '.manifest'
    data = eval(file(manifest).read())
    new_name = data[1]['digest']
    data[1]['filename'] = 'clang.tar.bz2'
    data = [{'clang_version' : 'r%s' % rev }] + data
    out = file(manifest,'w')
    simplejson.dump(data, out, indent=0, item_sort_key=key_sort)
    out.write('\n')
    os.rename(old_name, new_name)

#!/bin/sh

set -e
rm -f *.manifest tooltool.py setup.sh

curl -O https://raw.github.com/jhford/tooltool/master/tooltool.py
curl -O https://hg.mozilla.org/mozilla-central/raw-file/tip/build/unix/build-clang/setup.sh
python tooltool.py -m linux32.manifest add clang-linux32.tar.bz2 setup.sh
python tooltool.py -m linux64.manifest add clang-linux64.tar.bz2 setup.sh
python tooltool.py -m darwin.manifest add clang-darwin.tar.bz2 setup.sh

python ~/mozilla/create-manifest-aux.py

Comment 5

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: update the build script

Sorry, I should have known that bugs is handling visibility attributes are never alone. I have fixed a few more  of them and try is looking good so far with 160176:

https://tbpl.mozilla.org/?tree=Try&pusher=[e-mail]

Comment 6

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: update the clang manifest. To be committed after try is done.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bc145c1e0647
https://hg.mozilla.org/mozilla-central/rev/024c3fafd531