773014 - Add static analysis assertion that Static{Auto,Ref}Ptr is used only in global scope

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Justin Lebar (not reading bugmail)]

See bug 772987 -- Static{Auto,Ref}Ptr should be used only in global scope (where its mRawPtr is automatically initialized to 0).  Ehsan suggests enforcing this via static analysis.

Comment 1

[(no longer active)]

Attachment: Part 1: Add an analysis for marking classes as global-only

Comment 2

[(no longer active)]

Attachment: Part 2: Mark Static{Auto,Ref}Ptr as global-only

Comment 3

[(no longer active)]

Attachment: Part 1: Add an analysis for marking classes as global-only

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8536098 [details] [diff] [review]
Part 1: Add an analysis for marking classes as global-only

Review of attachment 8536098 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/clang-plugin/clang-plugin.cpp
@@ +38,5 @@
>      return astMatcher.newASTConsumer();
>    }
>  
>  private:
> +  class LocalGlobalClassChecker : public MatchFinder::MatchCallback {

LocalGlobal is a poor name. ScopeClassChecker would be better or even maybe just ScopeChecker.

Comment 5

[(no longer active)]

Note to self: jrmuizel voted for MOZ_ONLY_USED_TO_AVOID_STATIC_CONSTRUCTORS.

Comment 6

[(no longer active)]

Attachment: Part 1: Add an analysis for marking classes as global-only

Comment 7

[(no longer active)]

Attachment: Part 2: Mark Static{Auto,Ref}Ptr as global-only

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/baf97266ac9b
https://hg.mozilla.org/mozilla-central/rev/6b3f00c078b1