Do not use large menus on Gingerbread devices.

VERIFIED FIXED in Firefox 15

Status

()

Firefox for Android
Theme and Visual Design
VERIFIED FIXED
5 years ago
11 months ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

16 Branch
Firefox 16
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox15 verified, firefox16 verified, firefox17 verified)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I was hitting the following exception when trying to open the browser menu. The Gingerbread Galaxy Note thinks it is a "large" device, but fails to load the menu-large resources.

java.lang.NullPointerException
	at org.mozilla.gecko.BrowserApp.onPrepareOptionsMenu(BrowserApp.java:592)
	at android.app.Activity.onPreparePanel(Activity.java:2196)
	at org.mozilla.gecko.GeckoApp.onPreparePanel(GeckoApp.java:595)
	at com.android.internal.policy.impl.PhoneWindow.preparePanel(PhoneWindow.java:359)
	at com.android.internal.policy.impl.PhoneWindow.onKeyDownPanel(PhoneWindow.java:602)
	at com.android.internal.policy.impl.PhoneWindow.onKeyDown(PhoneWindow.java:1276)
	at com.android.internal.policy.impl.PhoneWindow$DecorView.dispatchKeyEvent(PhoneWindow.java:1850)
	at android.view.ViewRoot.deliverKeyEventToViewHierarchy(ViewRoot.java:2813)
	at android.view.ViewRoot.handleFinishedEvent(ViewRoot.java:2774)
	at android.view.ViewRoot.handleMessage(ViewRoot.java:1992)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:130)
	at android.app.ActivityThread.main(ActivityThread.java:3691)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:507)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:912)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:670)
	at dalvik.system.NativeStart.main(Native Method)
(Assignee)

Comment 1

5 years ago
Created attachment 641253 [details] [diff] [review]
menu-large-v11.patch

Do not use "large" menus on Gingerbread devices.
Attachment #641253 - Flags: review?(sriram)
(Assignee)

Updated

5 years ago
Blocks: 770079
Comment on attachment 641253 [details] [diff] [review]
menu-large-v11.patch

Review of attachment 641253 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.
Please remove the logs :)
r+ with that change.
Attachment #641253 - Flags: review?(sriram) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/69f5207c57c8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
status-firefox16: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Comment on attachment 641253 [details] [diff] [review]
menu-large-v11.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Note! Really? How can it a LARGE device on gingerbread?
User impact if declined: Note running GB will crash.
Testing completed (on m-c, etc.): Landed on m-c on 07/12
Risk to taking this patch (and alternatives if risky): None.
String or UUID changes made by this patch: None.

The comments in the patch were removed, while pushing the code to m-c. Same will be done for aurora too.
Attachment #641253 - Flags: approval-mozilla-aurora?

Comment 5

5 years ago
Comment on attachment 641253 [details] [diff] [review]
menu-large-v11.patch

[Triage Comment]
Basically no risk, so no reason to wait on uplift.
Attachment #641253 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/integration/mozilla-inbound/rev/9368a54926a5 accidentally landed with this bug number; it is actually from related bug 773735.
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/7140e39a6427
status-firefox15: unaffected → fixed
https://hg.mozilla.org/mozilla-central/rev/9368a54926a5

Updated

5 years ago
Duplicate of this bug: 766861
(Assignee)

Comment 10

5 years ago
(In reply to Ryan VanderMeulen from comment #8)
> https://hg.mozilla.org/mozilla-central/rev/9368a54926a5

btw, cset 9368a54926a5 is for a different bug which inadvertently listed this bug's number. I landed this bug's fix on m-c two days ago in cset 69f5207c57c8.

Updated

5 years ago
Duplicate of this bug: 760357
WFM via HTC Nexus One (Android 2.3.4)
Status: RESOLVED → VERIFIED
status-firefox15: fixed → verified
status-firefox16: fixed → verified
status-firefox17: --- → verified

Updated

5 years ago
Duplicate of this bug: 767713

Updated

5 years ago
Duplicate of this bug: 739074
You need to log in before you can comment on or make changes to this bug.