Closed
Bug 773131
Opened 13 years ago
Closed 13 years ago
Change the country/region name of Taiwan from "Taiwan, Province of China" to simply "Taiwan"
Categories
(Webmaker Graveyard :: General, defect)
Webmaker Graveyard
General
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: bobchao, Assigned: andrew)
Details
When mentioned country/region name in webmaker.org [1], we should use "Taiwan" instead of "Taiwan, Province of China" in ISO 3166-1. The issue has been discussed in Bug 230866 and Bug 356038, and I think we can just follow the best practice, which is:
i. Use "Country/Region" for the label of country name selection.
ii. Use "Taiwan" instead of "Taiwan, Province of China."
Thanks
[1] for example, the title of this page: https://webmaker.org/en-US/events/in/tw/
Updated•13 years ago
|
Assignee: nobody → andrew
Comment 1•13 years ago
|
||
One thing we're going to have to do is check our data source for country names, we might have to change things there before they merge down.
Assignee | ||
Comment 2•13 years ago
|
||
We are currently getting our country names from this project:
https://bitbucket.org/smileychris/django-countries/
It looks like the issue of certain names (including Taiwan) has been raised already:
https://bitbucket.org/smileychris/django-countries/issue/16/capitalization-and-diacritics-in-some
I believe that project's name list is directly generated from the ISO-3166-1 data found here:
http://www.iso.org/iso/country_names_and_code_elements_txt
Unfortunately, as Ross has already said, the best place for changes to be made is in that project, as we don't have the source directly in our code. So, without wishing to seem like we're just hoisting this off on someone else, feel free to add your voice to the django-countries ticket (see above). I appreciate the political concern of this bug, and I apologise for not pursuing the matter further, but between the two of us we don't have time to go chasing external data sources.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
Reporter | ||
Comment 3•13 years ago
|
||
So if someone fix that problem in the project you mentioned, will webmaker.org apply the change of that part automatically?
I will try to find someone fix that bug, but I need to make sure that it helps our website.
Assignee | ||
Comment 4•13 years ago
|
||
Yes, if/when django-countries updates it's country names, that will essentially be pulled automatically into the webmaker.org site.
Comment 5•13 years ago
|
||
(In reply to Andrew Hayward from comment #4)
> Yes, if/when django-countries updates it's country names, that will
> essentially be pulled automatically into the webmaker.org site.
Andrew. I don't complaint you for using a name list with typo on my name. But, I complaint you if you still insist to use a typo on my name after I have pointed out the typo. Could you fix the typo on my name?
Assignee | ||
Comment 6•13 years ago
|
||
(In reply to Thinker Li [:sinker] from comment #5)
> Andrew. I don't complaint you for using a name list with typo on my name.
> But, I complaint you if you still insist to use a typo on my name after I
> have pointed out the typo. Could you fix the typo on my name?
I'm not entirely sure what you're asking for. Unfortunately, we can't just fix the naming problem, as I tried to explain above - it's not as simple as being a 'typo' in our system.
You need to log in
before you can comment on or make changes to this bug.
Description
•