Make removal of iframe more robust

RESOLVED FIXED in Firefox 16

Status

()

Product:
Firefox
Component:
SocialAPI
Status:
RESOLVED FIXED
Reported:
6 years ago
Modified:
6 years ago

People

(Reporter: markh, Assigned: markh)

Tracking

Version:
unspecified
Target:
Firefox 16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

remove iframe using this.frame.parentNode.removeChild
903 bytes, patch
dao
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
6 years ago 
Created attachment 641382 [details] [diff] [review]
remove iframe using this.frame.parentNode.removeChild

From https://bugzilla.mozilla.org/show_bug.cgi?id=770679#c2
Attachment #641382 - Flags: review?(gavin.sharp)

Updated

•
6 years ago
Attachment #641382 - Flags: review?(gavin.sharp) → review+
 (Assignee)

Comment 1

•
6 years ago 
Pushed to inbound at https://hg.mozilla.org/integration/mozilla-inbound/rev/184ba174e8a6
OS: Windows 7 → All
Hardware: x86_64 → All

Comment 2

•
6 years ago 
Backed out and relanded with me as the reviewer:
http://hg.mozilla.org/integration/mozilla-inbound/rev/cf874e608c60

Also added the missing semicolon while I was at it.
Target Milestone: --- → Firefox 16

Comment 3

•
6 years ago 
https://hg.mozilla.org/mozilla-central/rev/cf874e608c60
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.