Last Comment Bug 773165 - Make removal of iframe more robust
: Make removal of iframe more robust
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: SocialAPI (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Firefox 16
Assigned To: Mark Hammond [:markh]
:
Mentors:
Depends on:
Blocks: 770679
  Show dependency treegraph
 
Reported: 2012-07-12 00:24 PDT by Mark Hammond [:markh]
Modified: 2012-07-16 14:13 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
remove iframe using this.frame.parentNode.removeChild (903 bytes, patch)
2012-07-12 00:24 PDT, Mark Hammond [:markh]
dao+bmo: review+
Details | Diff | Splinter Review

Description Mark Hammond [:markh] 2012-07-12 00:24:18 PDT
Created attachment 641382 [details] [diff] [review]
remove iframe using this.frame.parentNode.removeChild

From https://bugzilla.mozilla.org/show_bug.cgi?id=770679#c2
Comment 1 Mark Hammond [:markh] 2012-07-12 01:06:35 PDT
Pushed to inbound at https://hg.mozilla.org/integration/mozilla-inbound/rev/184ba174e8a6
Comment 2 Dão Gottwald [:dao] 2012-07-12 01:26:51 PDT
Backed out and relanded with me as the reviewer:
http://hg.mozilla.org/integration/mozilla-inbound/rev/cf874e608c60

Also added the missing semicolon while I was at it.
Comment 3 Ed Morley [:emorley] 2012-07-12 09:35:52 PDT
https://hg.mozilla.org/mozilla-central/rev/cf874e608c60

Note You need to log in before you can comment on or make changes to this bug.