Closed Bug 773165 Opened 10 years ago Closed 10 years ago

Make removal of iframe more robust

Categories

(Firefox Graveyard :: SocialAPI, defect)

Product:
Firefox Graveyard
Component:
SocialAPI
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 16

People

(Reporter: markh, Assigned: markh)

References

Details

Attachments

(1 file)

remove iframe using this.frame.parentNode.removeChild
903 bytes, patch
dao
: review+
Details | Diff | Splinter Review
Attachment #641382 - Flags: review?(gavin.sharp) → review+
Pushed to inbound at https://hg.mozilla.org/integration/mozilla-inbound/rev/184ba174e8a6
OS: Windows 7 → All
Hardware: x86_64 → All
Backed out and relanded with me as the reviewer:
http://hg.mozilla.org/integration/mozilla-inbound/rev/cf874e608c60

Also added the missing semicolon while I was at it.
Target Milestone: --- → Firefox 16
https://hg.mozilla.org/mozilla-central/rev/cf874e608c60
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.