Closed
Bug 773225
Opened 13 years ago
Closed 13 years ago
GCLI selected element should be clearer in menus
Categories
(DevTools :: Console, defect, P1)
DevTools
Console
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 16
People
(Reporter: jwalker, Assigned: jwalker)
Details
Attachments
(1 file)
|
2.14 KB,
patch
|
msucan
:
review+
|
Details | Diff | Splinter Review |
We should use 'transparent' black at least.
|
Assignee | |
Updated•13 years ago
|
Component: Developer Tools → Developer Tools: Console
Priority: -- → P1
Target Milestone: --- → Firefox 16
|
|
Assignee | |
Comment 1•13 years ago
|
||
I couldn't make the black and blacker (without making it non-translucent) so I've swapped the highlight colors.
Not to say that this one isn't also without problems because we have off-white text too.
Does this help?
|
||
Comment 2•13 years ago
|
||
Comment on attachment 641774 [details] [diff] [review]
v1
This is an improvement in contrast, but I feel it's not enough contrast. I would suggest background-color: #000; color: #fff. I tested this and it looks better.
Not sure if there's any benefit/requirement to have the highlighted element translucent.
Leaving the final choice to you. Giving r+. Thank you!
Attachment #641774 -
Flags: review?(mihai.sucan) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Whiteboard: [fixed-in-fx-team]
|
|
||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•