Closed Bug 773268 Opened 12 years ago Closed 12 years ago

Tabs.java uses "selectedTab" as a variable name for both class and local variables

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 16

People

(Reporter: kats, Assigned: kats)

Details

Attachments

(1 file)

Patch
7.41 KB, patch
bnicholson
: review+
Details | Diff | Splinter Review 
This is an accident waiting to happen. Class variables in Tabs.java should be renamed to be mXxxx as per our coding convention.
Attached patch Patch — — Splinter Review 

        Attachment #641936 -
        Flags: review?(bnicholson)

    
    

    
  
Comment on attachment 641936 [details] [diff] [review]
Patch

Nice, thanks.

        Attachment #641936 -
        Flags: review?(bnicholson) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/c0f0844797ba
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Product: Firefox for Android → Firefox for Android Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: