773276 - WebGL link errors when building with WebGL disabled

Status: RESOLVED INVALID

(Core :: Graphics: CanvasWebGL, defect)

Description

[Brian King [:kinger]]

I'm building comm-central on Windows, with webgl disabled. Here is my .mozconfig:

ac_add_options --disable-angle
ac_add_options --enable-chrome-format=symlink
ac_add_options --disable-webgl

However, there are link errors related to WebGL. Here is a sampling:

WebGLRenderingContextBinding.obj : error LNK2019: unresolved external symbol "pu
blic: void __thiscall mozilla::WebGLContext::GetSupportedExtensions(struct mozil
la::dom::Nullable<class nsTArray<class nsString,struct nsTArrayDefaultAllocator>
 > &)" (?GetSupportedExtensions@WebGLContext@mozilla@@QAEXAAU?$Nullable@V?$nsTAr
ray@VnsString@@UnsTArrayDefaultAllocator@@@@@dom@2@@Z) referenced in function "i
nt __cdecl mozilla::dom::WebGLRenderingContextBinding::getSupportedExtensions(st
ruct JSContext *,unsigned int,class JS::Value *)" (?getSupportedExtensions@WebGL
RenderingContextBinding@dom@mozilla@@YAHPAUJSContext@@IPAVValue@JS@@@Z)
WebGLRenderingContextBinding.obj : error LNK2019: unresolved external symbol "pu
blic: void __thiscall mozilla::WebGLContext::GetAttachedShaders(class mozilla::W
ebGLProgram *,struct mozilla::dom::Nullable<class nsTArray<class mozilla::WebGLS
hader *,struct nsTArrayDefaultAllocator> > &)" (?GetAttachedShaders@WebGLContext
@mozilla@@QAEXPAVWebGLProgram@2@AAU?$Nullable@V?$nsTArray@PAVWebGLShader@mozilla
@@UnsTArrayDefaultAllocator@@@@@dom@2@@Z) referenced in function "int __cdecl mo
zilla::dom::WebGLRenderingContextBinding::getAttachedShaders(struct JSContext *,
unsigned int,class JS::Value *)" (?getAttachedShaders@WebGLRenderingContextBindi
ng@dom@mozilla@@YAHPAUJSContext@@IPAVValue@JS@@@Z)
xul.dll : fatal error LNK1120: 139 unresolved externals
make[5]: *** [xul.dll] Error 96
make[5]: Leaving directory `/c/mozilla/builds/tb/comm-central/obj-i686-pc-mingw3
2/mozilla/toolkit/library'
make[4]: *** [libs_tier_platform] Error 2
make[4]: Leaving directory `/c/mozilla/builds/tb/comm-central/obj-i686-pc-mingw3
2/mozilla'
make[3]: *** [tier_platform] Error 2
make[3]: Leaving directory `/c/mozilla/builds/tb/comm-central/obj-i686-pc-mingw3
2/mozilla'
make[2]: *** [default] Error 2
make[2]: Leaving directory `/c/mozilla/builds/tb/comm-central/obj-i686-pc-mingw3
2/mozilla'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/c/mozilla/builds/tb/comm-central/obj-i686-pc-mingw3
2'
make: *** [build] Error 2

Comment 1

[Mark Banner (:standard8)]

This feels like a mozilla-central issue to me in WebGL, maybe those functions should be defined in http://mxr.mozilla.org/comm-central/source/mozilla/content/canvas/src/WebGLContextNotSupported.cpp

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

I'd really like to see a complete build log, please. I'd try myself, but I'm already rushing to fix other bugs.

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

Trying now...

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Build succeeded for me on Win7 / MSVC2010 with this mozconfig:

. $topsrcdir/browser/config/mozconfig
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-firefox-debug-no-webgl
mk_add_options MOZ_MAKE_FLAGS="-j8"
ac_add_options --disable-optimize
ac_add_options --enable-debug 
ac_add_options --enable-tests
ac_add_options --disable-webgl


I suggest that you clobber and retry. Also, from your mozconfig, drop the --disable-angle, this option doesn't exist anymore (this is implied by --disable-webgl).

Comment 5

[Kelsey Gilbert [:jgilbert]]

If this isn't still a problem, we can close this bug.

Comment 6

[Brian King [:kinger]]

I don't have any extra input on this as I don't have a build environment set up and don't foresee having one soon. Will defer to :bjacob in comment 4.