Closed Bug 773293 Opened 7 years ago Closed 7 years ago

Checkboxes in Send Tab To Device activity are using non-OS theme

Categories

(Firefox for Android :: Android Sync, defect, P3)

ARM
Android
defect

Tracking

()

VERIFIED FIXED
mozilla18
Tracking Status
firefox16 --- affected
firefox18 --- verified
fennec + ---

People

(Reporter: aaronmt, Assigned: nalexander)

References

()

Details

(Keywords: polish)

Attachments

(2 files)

See screenshot, I'm on Jellybean but the checkboxes are for Gingerbread.

--
Nightly (07/12)
Samsung Galaxy Nexus (Android 4.1.1)
(If it's not clear, they're supposed to be blue http://compixels.com/wp-content/uploads/2012/01/ICS-Browser+-Advanced-Settings.png).
Keywords: polish
Component: General → Android Sync
Product: Firefox for Android → Mozilla Services
Version: Trunk → unspecified
Is it like this for ICS too?
tracking-fennec: ? → 16+
*blink*
Summary: Checkboxes on Sync List Item (XML layout) are using non-OS theme → Checkboxes in Send Tab To Device activity are using non-OS theme
Priority: -- → P3
(In reply to Mark Finkle (:mfinkle) from comment #2)
> Is it like this for ICS too?

Yes
tracking-fennec: 16+ → +
Assignee: nobody → nalexander
Hi sriram, how do you feel about adding Gecko.Dialog to resources/values/themes.xml?  I would like to add it so that SyncTheme can inherit from Gecko (on phone) or Gecko.Dialog (on tablet, sees mocks at Bug 767179) and that future Gecko theming propagates to the Sync UI as much as possible.
Attachment #654807 - Flags: feedback?(sriram)
Not a hard dep, but I'd like to land this after Bug 767179 lands.
Comment on attachment 654807 [details] [diff] [review]
Patch against m-i

Review of attachment 654807 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.
Attachment #654807 - Flags: feedback?(sriram) → feedback+
Comment on attachment 654807 [details] [diff] [review]
Patch against m-i

Review of attachment 654807 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/resources/values-v11/themes.xml
@@ +9,5 @@
>          <item name="android:windowContentOverlay">@null</item>
>          <item name="android:windowActionBar">false</item>
>          <item name="android:windowNoTitle">true</item>
>      </style>
>      

Trailing whitespace.

@@ +15,5 @@
> +        <item name="android:windowContentOverlay">@null</item>
> +        <item name="android:windowActionBar">false</item>
> +        <item name="android:windowNoTitle">true</item>
> +    </style>
> +    

Trailing whitespace.

::: mobile/android/base/resources/values/themes.xml
@@ +13,5 @@
> +    <style name="Gecko.Dialog" parent="@android:style/Theme.Dialog">
> +        <item name="android:windowNoTitle">true</item>
> +        <item name="android:windowContentOverlay">@null</item>
> +    </style>
> +    

Aaaarg
Attachment #654807 - Flags: review+
Looks nice!

Uplift or ride it?
Status: RESOLVED → VERIFIED
This should probably move in lockstep with Bug 767179 (tablet UI).  Let's get some feedback on that, and then consider uplifting both.
Nit: Why are row highlights orange (not the default system theme)?
(In reply to Aaron Train [:aaronmt] from comment #13)
> Nit: Why are row highlights orange (not the default system theme)?

As I understand it, we now share Fennec's styles.
Product: Mozilla Services → Android Background Services
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.