77334 - images not always clipped as they should be

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Image: Painting, defect)

Description

[Asko Tontti]

I noticed a bug in the fix for bug 74270 and I reported it. Despite that
the buggy patch was reviewed and checked in to the trunk.

So I am opening a new bug for fixing nsImageGTK::Draw and
nsImageGTK::DrawScaled.

We should be clipping the source rectangle with decoded rectangle (mDecoded*)
but now instead of clipping we are moving the source rectangle in some
situations.

Comment 1

[Asko Tontti]

Attachment: patch: clip source rectangle - don't move it

Comment 2

[Asko Tontti]

comments or r/sr needed.

Comment 3

[Boris Zbarsky [:bzbarsky]]

pavlo, tor, reviews?

Comment 4

[tor]

r=tor

Comment 5

[Asko Tontti]

Attachment: updated patch

Comment 6

[Asko Tontti]

In one point I had mixed up width and height although comment was right :(

Comment 7

[chris hofmann]

can somebody show a test case so we can see the affect of this
and make some guesses about how wide spread the bug might appear.

need to shut down 0.9.  don't want to take this if its not critcal

Comment 8

[Asko Tontti]

Not critical for 0.9

Comment 9

[Stuart Parmenter]

can you post a new diff against the trunk since most of the patch here is
already in the tree.

Comment 10

[Asko Tontti]

There don't seem to be need for updating the current diff (id=32018).
It is still valid.

Comment 11

[Asko Tontti]

r/sr needed for the updated patch.

Comment 12

[chris hofmann]

let's land this in 0.9.2. let drivers know if this creates problems. thanks.
somebody jump on the reviews...

Comment 13

[tor]

r=tor

Comment 14

[Tom Mraz]

*** Bug 84080 has been marked as a duplicate of this bug. ***

Comment 15

[Tom Mraz]

Maybe you could test it with GIFs from the duplicate bug.

Comment 16

[Markus Hübner]

what's the current status?!

Comment 17

[Asko Tontti]

Bug 84080 is not a dup of this bug. I marked 84080 as invalid. More information
can be found at that bug.

Comment 18

[Blake Ross]

Missed 0.9.3.

Comment 19

[Markus Hübner]

what's the current status of this one?!

Comment 20

[Kelly Price]

Bug 84080 was reopened, but not as a dup of this bug.  Is bug 22607 related to
this one?

Comment 21

[Azrael AOD]

Attachment: Animated transparent background gif

Comment 22

[Stephen Anderson]

Are the attached patches valid, invalid, in need of review, or super-review?

Comment 23

[Asko Tontti]

Kelly Price: no, this is not related to bug 22607 and bug 84080 is a dup of
bug 22607 (libpr0n doesn't implement DISPOSE_OVERWRITE_BGCOLOR properly).

Azrael AOD: problems with attachment 49331 [details] (image/gif) are happening due
bug 22607.

--
This bug is about incorrect clipping code in Mozilla's GTK code for Linux and
Unix. If mDecodedX1 or mDecodedY1 are nonzero Draw/DrawScaled() will move
region - not clip it to fit inside mDecoded*. Normally mDecodedX1 and mDecodedY1
are zero so you won't see this bug.

Comment 24

[Asko Tontti]

Comment on attachment 32018 [details] [diff] [review]
updated patch

I already have r=tor for this patch but I need sr= and moa= if I have
understood right.

pavlov, could you help?

Comment 25

[basic]

what's going on here?!?

Comment 26

[Stuart Parmenter]

tor is rewriting this code.. not sure how useful this patch still is...

Comment 27

[basic]

the bug # for tor's rewrite is bug 121015

Comment 28

[Fuzzy Gorilla]

The Target Milestone (0.9.7) is passed.  This bug should be retargeted.
The fix for bug 121015 was checked in on 2002-02-22.  Is the attached
patch still necessary?  If not, this bug should just be closed.

Comment 29

[basic]

is this bug still needed? Asko, are you still working on this?

Comment 30

[Asko Tontti]

Attachment: updated patch for "clip to decode region"

Comment 31

[Asko Tontti]

The bug doesn't seem to be fixed so I made an updated patch. I don't have time
to compile or test it.

You can see the problem more clearly by comparing codes of "clip to decode region"
and "clip to drawing surface" in the current version of nsImageGTK::Draw().

I'm currently on leave of my official duties so I am reading my email irregularly.
To tor.

Comment 32

[Vedran Miletic]

retargeting