mozAfterPaint/tpmozafterpaint broken and has been for awhile

RESOLVED FIXED

Status

Testing
Talos
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jeff Hammel, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Using a PerfConfigurator command:

PerfConfigurator --activeTests
tscroll:a11y:ts_paint:tpaint:tdhtml:tsspider --mozAfterPaint -e `which
firefox` --develop

The resulting firefox command line becomes:

DEBUG: command line: /home/jhammel/firefox/firefox  -profile
/tmp/tmpult93I/profile -tp
file:/home/jhammel/talos/talos/page_load_test/scroll/scroll.manifest.develop
-tpchrome -tpnoisy -tpformat tinderbox -tpcycles 5 -tppagecycles 1

This doesn't have -tpmozafterpaint which it should:

http://hg.mozilla.org/build/talos/file/tip/talos/run_tests.py#l124

This is a fairly serious bug.  I'm not entirely sure of the
implications, but almost assuredly our numbers have been borked :(
this might be really serious, lets get this fixed asap
(Reporter)

Comment 2

5 years ago
Created attachment 641641 [details] [diff] [review]
fix (?)

So this was me stupidly not outputting tpmozafterpaint from test.py.  This has been around for awhile. As far as I know, we don't need to output this for ts tests.  :jmaher, is that correct? If we do, it is easy to add

I'm not sure what to do about landing this.  This will affect numbers and has been broken for awhile :(  I'm sorry for screwing this up
Attachment #641641 - Flags: review?(jmaher)
(Reporter)

Comment 3

5 years ago
pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=c094aeea5f73
Comment on attachment 641641 [details] [diff] [review]
fix (?)

Review of attachment 641641 [details] [diff] [review]:
-----------------------------------------------------------------

this might not affect numbers too much.  Remember, I hosed them for 2 full days :)  Now we have a tool to help us compare.
Attachment #641641 - Flags: review?(jmaher) → review+
(Reporter)

Comment 5

5 years ago
Created attachment 641931 [details]
crunched numbers from jmaher's compare.py

This doesn't look like it affects numbers significantly.
(Reporter)

Comment 6

5 years ago
pushed: http://hg.mozilla.org/build/talos/rev/a927149bb18e
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.