Disable pdf.js prior to FF15 beta 5

VERIFIED FIXED in Firefox 15

Status

()

defect
VERIFIED FIXED
7 years ago
6 years ago

People

(Reporter: akeybl, Assigned: bdahl)

Tracking

unspecified
Firefox 15
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox15+ verified)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

7 years ago
Asa let us know that we'll keep pdf.js on the test channels till at least FF16's release, so we'll need to disable pdf.js prior to FF15's release.
Reporter

Updated

7 years ago
Summary: Disable pdf.js in our final Beta 14 build → Disable pdf.js in our final Beta 15 build
Assigning this to Brendan for now - Brendan are you the best person to have as the point person for disabling this when the time comes? If not, please re-assign to the person who will be.
Assignee: nobody → bdahl
Assignee

Comment 2

7 years ago
I can create a patch to disable it, though I don't have commit access.  To disable it will require changing one line(http://mxr.mozilla.org/mozilla-beta/source/browser/app/profile/firefox.js#1165) to true.
(In reply to Brendan Dahl from comment #2)
> I can create a patch to disable it, though I don't have commit access.  To
> disable it will require changing one
> line(http://mxr.mozilla.org/mozilla-beta/source/browser/app/profile/firefox.
> js#1165) to true.

If you can prepare the patch, and get it reviewed, we can flag this as checkin-needed in time for the last beta.
Assignee

Comment 4

7 years ago
Posted patch disable pdf.js (obsolete) — Splinter Review
Reporter

Updated

7 years ago
Summary: Disable pdf.js in our final Beta 15 build → Disable pdf.js prior to FF15 beta 5
Reporter

Comment 5

7 years ago
I think it would be more prudent to disable for our second to last beta, just in case.
Assignee: bdahl → gavin.sharp
Assignee: gavin.sharp → bdahl
Attachment #646630 - Flags: review+
Attachment #646630 - Flags: approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-beta/rev/7488058a7c3f
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Backed out at Gavin's request for browser_pdfjs_main.js failures:
https://tbpl.mozilla.org/?tree=Mozilla-Beta&rev=7488058a7c3f

https://hg.mozilla.org/releases/mozilla-beta/rev/a9b08621c0f3
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee

Comment 8

7 years ago
Attachment #646630 - Attachment is obsolete: true
https://hg.mozilla.org/releases/mozilla-beta/rev/aff8c2ba16dd
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:15.0) Gecko/20100101 Firefox/15.0
Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20100101 Firefox/15.0
Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20100101 Firefox/15.0

PDF.js was successfully disabled in Firefox 15.0beta5: "Preview in Firefox" option is not available for handling PDFs.
Status: RESOLVED → VERIFIED
Keywords: verifyme
QA Contact: moz.mihaelav
Reporter

Updated

7 years ago
Blocks: 786012
When updating pdf.js 0.4.11 for Firefox 17, it lacked pdfjs/content/web/images/toolbarButton-fullscreen.png. And this lacking is continued in aurora 17.

At nightly 18, I sent a patch (bug 784718), and the patch will be checked-in within days.
Should we check-in it for aurora 17 too? Although disable pdf.js on aurora 17 by this bug's patch, I think that we keep a source-tree as cleanly. This filling does not cause any regression.
(In reply to OHZEKI Tetsuharu [:saneyuki_s] from comment #11)
> When updating pdf.js 0.4.11 for Firefox 17, it lacked
> pdfjs/content/web/images/toolbarButton-fullscreen.png. And this lacking is
> continued in aurora 17.
> 
> At nightly 18, I sent a patch (bug 784718), and the patch will be checked-in
> within days.
> Should we check-in it for aurora 17 too? Although disable pdf.js on aurora
> 17 by this bug's patch, I think that we keep a source-tree as cleanly. This
> filling does not cause any regression.

Opps! I mistake the bug number.
Please read as following:
bug 784718 -> bug 786219
Reporter

Comment 13

7 years ago
(In reply to OHZEKI Tetsuharu [:saneyuki_s] from comment #11)
> When updating pdf.js 0.4.11 for Firefox 17, it lacked
> pdfjs/content/web/images/toolbarButton-fullscreen.png. And this lacking is
> continued in aurora 17.
> 
> At nightly 18, I sent a patch (bug 784718), and the patch will be checked-in
> within days.
> Should we check-in it for aurora 17 too? Although disable pdf.js on aurora
> 17 by this bug's patch, I think that we keep a source-tree as cleanly. This
> filling does not cause any regression.

PDF.js is now disabled in FF17 (bug 786012). No need to uplift.
Gavin, is there a bug filed (/plan) for the Nightly-only xpcshell failures on aurora due to aff8c2ba16dd ?
(In reply to Ed Morley [:edmorley] from comment #14)
> Gavin, is there a bug filed (/plan) for the Nightly-only xpcshell failures

Just noticed that the aurora commit landed with the wrong bug number, I'll move this discussion to bug 786012.
You need to log in before you can comment on or make changes to this bug.