when running tests, freeze WebappRT config object after calling confirmInstall()

RESOLVED FIXED in Firefox 16

Status

Firefox Graveyard
Webapp Runtime
P1
normal
RESOLVED FIXED
5 years ago
a year ago

People

(Reporter: myk, Assigned: myk)

Tracking

14 Branch
Firefox 16

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 641574 [details] [diff] [review]
patch v1: freezes object after calling confirmInstall()

When running tests WebappRT.jsm freezes the configuration object before calling DOMApplicationRegistry.confirmInstall(), but confirmInstall() sets the object's installTime property, which fails after the object is frozen (causing tests to fail).

WebappRT.jsm should freeze the configuration object *after* calling confirmInstall().
Attachment #641574 - Flags: review?(adw)

Comment 1

5 years ago
Comment on attachment 641574 [details] [diff] [review]
patch v1: freezes object after calling confirmInstall()

Review of attachment 641574 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #641574 - Flags: review?(adw) → review+

Updated

5 years ago
Priority: -- → P1
(Assignee)

Comment 2

5 years ago
Comment on attachment 641574 [details] [diff] [review]
patch v1: freezes object after calling confirmInstall()

https://hg.mozilla.org/integration/mozilla-inbound/rev/260f3b5e03f4
Attachment #641574 - Flags: checkin+

Updated

5 years ago
Whiteboard: [qa-]
https://hg.mozilla.org/mozilla-central/rev/260f3b5e03f4
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.