Last Comment Bug 773411 - when running tests, freeze WebappRT config object after calling confirmInstall()
: when running tests, freeze WebappRT config object after calling confirmInstall()
Status: RESOLVED FIXED
[qa-]
:
Product: Firefox Graveyard
Classification: Graveyard
Component: Webapp Runtime (show other bugs)
: 14 Branch
: All All
: P1 normal
: Firefox 16
Assigned To: Myk Melez [:myk] [@mykmelez]
: Jason Smith [:jsmith]
Mentors:
Depends on:
Blocks: 770771
  Show dependency treegraph
 
Reported: 2012-07-12 13:19 PDT by Myk Melez [:myk] [@mykmelez]
Modified: 2016-03-21 12:39 PDT (History)
2 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch v1: freezes object after calling confirmInstall() (750 bytes, patch)
2012-07-12 13:19 PDT, Myk Melez [:myk] [@mykmelez]
adw: review+
myk: checkin+
Details | Diff | Splinter Review

Description Myk Melez [:myk] [@mykmelez] 2012-07-12 13:19:22 PDT
Created attachment 641574 [details] [diff] [review]
patch v1: freezes object after calling confirmInstall()

When running tests WebappRT.jsm freezes the configuration object before calling DOMApplicationRegistry.confirmInstall(), but confirmInstall() sets the object's installTime property, which fails after the object is frozen (causing tests to fail).

WebappRT.jsm should freeze the configuration object *after* calling confirmInstall().
Comment 1 Drew Willcoxon :adw 2012-07-12 13:42:14 PDT
Comment on attachment 641574 [details] [diff] [review]
patch v1: freezes object after calling confirmInstall()

Review of attachment 641574 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Comment 2 Myk Melez [:myk] [@mykmelez] 2012-07-12 14:04:14 PDT
Comment on attachment 641574 [details] [diff] [review]
patch v1: freezes object after calling confirmInstall()

https://hg.mozilla.org/integration/mozilla-inbound/rev/260f3b5e03f4
Comment 3 Ed Morley [:emorley] 2012-07-13 05:32:23 PDT
https://hg.mozilla.org/mozilla-central/rev/260f3b5e03f4

Note You need to log in before you can comment on or make changes to this bug.