Closed Bug 773563 Opened 8 years ago Closed 6 years ago

Cleanup BTA_detach callers to avoid redundant state checks

Categories

(DevTools :: Debugger, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 29

People

(Reporter: past, Assigned: past)

References

Details

Attachments

(1 file)

From bug 751949 comment 9:

"Looking at _detach a bit more, we're doing a bunch of if (attached) _detach(). Probably some cleanup we could do around the senders of _detach() to check for a return of false in the detach() method and then do something special if needed. Suitable for followup."
Ask and (a year later) ye shall receive!
Attachment #8347174 - Flags: review?(rcampbell)
Comment on attachment 8347174 [details] [diff] [review]
Cleanup BTA_detach callers to avoid redundant state checks

Review of attachment 8347174 [details] [diff] [review]:
-----------------------------------------------------------------

k.
Attachment #8347174 - Flags: review?(rcampbell) → review+
https://hg.mozilla.org/mozilla-central/rev/81dd3e01279a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 29
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.