Closed Bug 77357 Opened 23 years ago Closed 23 years ago

xul grid loses track of column count.

Categories

(Core :: XUL, defect)

Product:
Core
Component:
XUL
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla0.9.6

People

(Reporter: pwilson, Assigned: eric)

Details

(Keywords: testcase)

Attachments

(7 files)

javascript used to fill grid.
1.45 KB, text/plain
Details
XUL for grid
1.10 KB, text/plain
Details
Patch for new grid code.
45.15 KB, patch
Details | Diff | Splinter Review
new patch
23.06 KB, patch
Details | Diff | Splinter Review
Ok one more time.
23.08 KB, patch
Details | Diff | Splinter Review
A few more ifdefs
5.17 KB, patch
Details | Diff | Splinter Review
Ok the patch one again.
7.15 KB, patch
bryner
: review+
hyatt
: superreview+
Details | Diff | Splinter Review 
If you fill a grid dynamically using javascript the grid can loose track of how 
many columns it should have. This happens when no rows are to be displayed. In 
this case no row elements are present. If you then rebuild the grid with data 
present the grid has collapesed to one column and remains that way.

See attachments for example code.

Also note it is neccessary to have a dummy row in the xul to get multiple 
columns to display.

    
    

    
  

      
      
      
      

        Attached file
          
        XUL for grid
        — 
      

    


  

    
    

    
  
over to XUL
Assignee: asa → trudelle
Component: Browser-General → XP Toolkit/Widgets: XUL
QA Contact: doronr → jrgm

    
    

    
  
->evaughan
Assignee: trudelle → evaughan

    
  
Summary: xul grid looses track of column count. → xul grid loses track of column count.
Target Milestone: --- → mozilla0.9.3

    
    

    
  
Marking NEW.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: testcase

    
    

    
  
Doesn't look like this is getting fixed before the freeze tomorrow night.
Pushing out a milestone.  Please correct if I'm mistaken.
Target Milestone: mozilla0.9.3 → mozilla0.9.4

    
    

    
  
-> 095
Target Milestone: mozilla0.9.4 → mozilla0.9.5

    
    

    
  
This is fixed by my new grid code. It will land next build.

Status: NEW → ASSIGNED
Target Milestone: mozilla0.9.5 → mozilla0.9.6

    
    

    
  


  

    
    

    
  
I patch has been made to add new grid code. The first part of the patch contains:

1) fix for box not setting parent pointer
2) changed to box to give grid more access
3) ifdefs so none of the new code is on by default to turn on define MOZ_GRID2

The new grid code is on the end of the patch but if you want really take a look
it can be found in the tree at mozilla/layout/xul/base/src/grid



    
    

    
  
Change the DEBUG_evaughan to a MOZ_GRID2.  Take the grid code, since it doesn't
need r/sr yet.  

r=hyatt


    
    

    
  

      
      
      
      

        Attached patch
          
          
        new patch
        — 
          — Splinter Review
      

    


  

    
    

    
  


  

    
    

    
  
sr=waterson

    
    

    
  


  

    
    

    
  


  

    
    

    
  
Comment on attachment 54145 [details] [diff] [review]
Ok the patch one again.

r=bryner

        Attachment #54145 -
        Flags: review+

    
    

    
  
Comment on attachment 54145 [details] [diff] [review]
Ok the patch one again.

sr=hyatt

        Attachment #54145 -
        Flags: superreview+

    
    

    
  
fixed
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED

    
  
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: