XBL fastload creates XUL element before feeding proto attributes to the protoelement

RESOLVED FIXED

Status

()

Core
XBL
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.67 KB, patch
Neil Deakin (mostly unavailable until September)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
nsXULElement::Create expects that it can check for example mHasClassAttribute value.
But that is just always false if the protoattributes are created after
the real DOM element.
(Assignee)

Comment 1

5 years ago
In practice this shouldn't matter much since the XUL element is used within XBL's not-yet-cloned content. But I'm investigating to disable using prototypes in XUL (for anything else but serializing and de-serializing) and noticed this inconsistency.
(Assignee)

Comment 2

5 years ago
Created attachment 641839 [details] [diff] [review]
patch

https://tbpl.mozilla.org/?tree=Try&rev=64f421f8386b
Assignee: nobody → bugs
Attachment #641839 - Flags: review?(enndeakin)
Attachment #641839 - Flags: review?(enndeakin) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/be26e809e6b1
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.