773672 - When leaving a page and coming back, restore previous content rather than warning the user before leaving

Status: VERIFIED FIXED

(developer.mozilla.org Graveyard :: Editing, defect, P2)

Description

[Dan Callahan [:callahad]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:16.0) Gecko/16.0 Firefox/16.0
Build ID: 20120706075126

Steps to reproduce:

Sometimes I accidentally trigger the Back function in my browser when editing a document on MDN. I then quickly go Forward to get back to editing.


Actual results:

All of my in-progress changes were gone.


Expected results:

A prompt to restore my in-progress changes, like with MindTouch, would be very, very nice.

Comment 1

[John Karahalis [:openjck]]

Raymond: Can you confirm on developer-new? Can you confirm on multiple browsers -- I think some preserve form contents in these circumstances.

Comment 4

[David Walsh :davidwalsh]

There's some code in place for this, going to continue it now.

Quick FYI -- we'll likely need to experiment with this.  *Storage interactions are synchronous, so we'll have to be careful not to sow the user down too much while writing and saving at the same time.

Comment 5

[John Karahalis [:openjck]]

From notes I took from TXJS:

* localStorage may slow down portions of your site, but the parts you are most worried about may not be a problem at all.
* Benchmark your JavaScript with [jsPerf](http://jsperf.com/).
* Best practices
    * Use window.onunload to store values after the user leaves.
    * Do not block the UI. Defer using localStorage until unload.
    * Do not save text entry in localStorage after every keystroke. Wait some length of time before saving.

Comment 6

[David Walsh :davidwalsh]

I'm skeptical about onunload but we'll give it a shot

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/bbb83cbb3a818da3ab2fbf453c3142773488b1a0
fix bug 773672 - Allow restoring of drafts when user leaves page

https://github.com/mozilla/kuma/commit/0a03c9b596ad5320981d84663fa7b6c02d7d756b
Merge pull request #547 from darkwing/localstorage-content-773672

fix bug 773672 - Allow restoring of drafts when user leaves page

Comment 8

[raymond [:retornam] (inactive)]

verified fixed https://developer.allizom.org/en-US/docs/HTML

Comment 9

[John Karahalis [:openjck]]

This is fantastic. Really, really wonderful UX.