Fix build warnings under accessible/

RESOLVED FIXED in mozilla17

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Tracking

unspecified
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 642114 [details] [diff] [review]
Patch
Attachment #642114 - Flags: review?(trev.saunders)
Comment on attachment 642114 [details] [diff] [review]
Patch


>   PRInt32 columnExtent = 0;
> 
>-  nsresult rv = tableLayout->
>+  mozilla::DebugOnly<nsresult> rv = tableLayout->

nit, add using namespace mozilla, and get rid of the mozilla::s

>     GetCellDataAt(aRowIdx, aColIdx, *getter_AddRefs(domElement),
>                   startRowIndex, startColIndex, rowSpan, colSpan,
>                   actualRowSpan, columnExtent, isSelected);
> 
>+  NS_ASSERTION(NS_SUCCEEDED(rv), "Could not get cell data");
>   return columnExtent;

nit, I'd put the blank line after the assert.

>-  nsresult rv = tableLayout->
>+  mozilla::DebugOnly<nsresult> rv = tableLayout->
>     GetCellDataAt(aRowIdx, aColIdx, *getter_AddRefs(domElement),
>                   startRowIndex, startColIndex, rowSpan, colSpan,
>                   rowExtent, actualColSpan, isSelected);
> 
>+  NS_ASSERTION(NS_SUCCEEDED(rv), "Could not get cell data");
>   return rowExtent;

same here

r=me with that
Attachment #642114 - Flags: review?(trev.saunders) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5acb040ec6f9
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/5acb040ec6f9
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.