Last Comment Bug 773839 - Fix build warnings under accessible/
: Fix build warnings under accessible/
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla17
Assigned To: David Zbarsky (:dzbarsky)
:
: alexander :surkov
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-13 15:50 PDT by David Zbarsky (:dzbarsky)
Modified: 2012-07-22 19:04 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (6.05 KB, patch)
2012-07-13 15:53 PDT, David Zbarsky (:dzbarsky)
tbsaunde+mozbugs: review+
Details | Diff | Splinter Review

Description David Zbarsky (:dzbarsky) 2012-07-13 15:50:55 PDT

    
Comment 1 David Zbarsky (:dzbarsky) 2012-07-13 15:53:15 PDT
Created attachment 642114 [details] [diff] [review]
Patch
Comment 2 Trevor Saunders (:tbsaunde) 2012-07-21 17:36:26 PDT
Comment on attachment 642114 [details] [diff] [review]
Patch


>   PRInt32 columnExtent = 0;
> 
>-  nsresult rv = tableLayout->
>+  mozilla::DebugOnly<nsresult> rv = tableLayout->

nit, add using namespace mozilla, and get rid of the mozilla::s

>     GetCellDataAt(aRowIdx, aColIdx, *getter_AddRefs(domElement),
>                   startRowIndex, startColIndex, rowSpan, colSpan,
>                   actualRowSpan, columnExtent, isSelected);
> 
>+  NS_ASSERTION(NS_SUCCEEDED(rv), "Could not get cell data");
>   return columnExtent;

nit, I'd put the blank line after the assert.

>-  nsresult rv = tableLayout->
>+  mozilla::DebugOnly<nsresult> rv = tableLayout->
>     GetCellDataAt(aRowIdx, aColIdx, *getter_AddRefs(domElement),
>                   startRowIndex, startColIndex, rowSpan, colSpan,
>                   rowExtent, actualColSpan, isSelected);
> 
>+  NS_ASSERTION(NS_SUCCEEDED(rv), "Could not get cell data");
>   return rowExtent;

same here

r=me with that
Comment 3 David Zbarsky (:dzbarsky) 2012-07-22 13:45:59 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/5acb040ec6f9
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-07-22 19:04:39 PDT
https://hg.mozilla.org/mozilla-central/rev/5acb040ec6f9

Note You need to log in before you can comment on or make changes to this bug.