773839 - Fix build warnings under accessible/

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Comment 2

[Trevor Saunders (:tbsaunde)]

Comment on attachment 642114 [details] [diff] [review]
Patch


>   PRInt32 columnExtent = 0;
> 
>-  nsresult rv = tableLayout->
>+  mozilla::DebugOnly<nsresult> rv = tableLayout->

nit, add using namespace mozilla, and get rid of the mozilla::s

>     GetCellDataAt(aRowIdx, aColIdx, *getter_AddRefs(domElement),
>                   startRowIndex, startColIndex, rowSpan, colSpan,
>                   actualRowSpan, columnExtent, isSelected);
> 
>+  NS_ASSERTION(NS_SUCCEEDED(rv), "Could not get cell data");
>   return columnExtent;

nit, I'd put the blank line after the assert.

>-  nsresult rv = tableLayout->
>+  mozilla::DebugOnly<nsresult> rv = tableLayout->
>     GetCellDataAt(aRowIdx, aColIdx, *getter_AddRefs(domElement),
>                   startRowIndex, startColIndex, rowSpan, colSpan,
>                   rowExtent, actualColSpan, isSelected);
> 
>+  NS_ASSERTION(NS_SUCCEEDED(rv), "Could not get cell data");
>   return rowExtent;

same here

r=me with that

Comment 3

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5acb040ec6f9

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5acb040ec6f9