Need to make sure that the binary we're using to symbolicate is the one generating the profile

NEW
Unassigned

Status

()

Core
Gecko Profiler
6 years ago
2 years ago

People

(Reporter: Ehsan, Unassigned)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

OK, this is a bit of an edge case, but I just started a second instance of Firefox, and then all of the native symbols in my profiles started to show webrtc and skia stuff calling each other which did not make any sense.  Then I realized that when I started the second Firefox instance, it updated and the binaries that the first instance used for symbolication had changed.

It would be great if we can avoid this problem somehow, as the stacks might be misleading.
Glandium do you have any idea how I could checksum a library easily. I may be asking for something impossible but the following properties would make life easier:
- Both the stripped and unstripped version would hash to the same.
- Ideally the same code could be used for libraries on all platform but I doubt that possible.
What breakpad does seems to work. I think it's hashing the first page of .text, but Ted would know better. OTOH, this is a fragile way of doing things, and we should eventually switch to using linker-generated uuids (although i don't know if msvc and mac ld can generate those).
(Reporter)

Comment 3

6 years ago
Why can't we just hash the binaries?  It will provide some false positives for sure, but I'm not sure we should care.
(In reply to Ehsan Akhgari [:ehsan] from comment #3)
> Why can't we just hash the binaries?  It will provide some false positives
> for sure, but I'm not sure we should care.

The binaries change when you strip them.
(Reporter)

Comment 5

6 years ago
(In reply to comment #4)
> (In reply to Ehsan Akhgari [:ehsan] from comment #3)
> > Why can't we just hash the binaries?  It will provide some false positives
> > for sure, but I'm not sure we should care.
> 
> The binaries change when you strip them.

Sure, but we're talking about the installed binaries that a user has, right?

Updated

5 years ago
Depends on: 779508

Updated

5 years ago
Duplicate of this bug: 830372
You need to log in before you can comment on or make changes to this bug.