Closed
Bug 773911
Opened 12 years ago
Closed 11 years ago
Inline js::GetContextCompartment
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
(Whiteboard: [js:t])
Attachments
(2 files)
5.18 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
1.94 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
Would make checks that stuff is in the right compartment faster.
Updated•12 years ago
|
Whiteboard: [js:t]
Updated•12 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #690034 -
Flags: review?(jwalden+bmo)
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #690035 -
Flags: review?(jwalden+bmo)
Assignee | ||
Updated•12 years ago
|
Assignee: general → bzbarsky
Whiteboard: [js:t] → [need review][js:t]
Comment 3•11 years ago
|
||
Comment on attachment 690034 [details] [diff] [review] part 1. Inline js::GetContextCompartment. Review of attachment 690034 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jspubtd.h @@ +271,2 @@ > ContextFriendFields(JSRuntime *rt) > + : runtime(rt), compartment(NULL) { } This was correctly indented two spaces. {} really belongs on a new line, tho, if we're going to touch anything here.
Attachment #690034 -
Flags: review?(jwalden+bmo) → review+
Comment 4•11 years ago
|
||
Comment on attachment 690035 [details] [diff] [review] part 2. Use the now-inline js::GetContextCompartment in a few places. Review of attachment 690035 [details] [diff] [review]: ----------------------------------------------------------------- rs=me
Attachment #690035 -
Flags: review?(jwalden+bmo) → review+
Assignee | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/79c26e82dfeb https://hg.mozilla.org/integration/mozilla-inbound/rev/ea066846993c
Flags: in-testsuite-
Whiteboard: [need review][js:t] → [js:t]
Target Milestone: --- → mozilla20
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/79c26e82dfeb https://hg.mozilla.org/mozilla-central/rev/ea066846993c
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•