Inline js::GetContextCompartment

RESOLVED FIXED in mozilla20

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

(Blocks 1 bug)

unspecified
mozilla20
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(2 attachments)

Would make checks that stuff is in the right compartment faster.
Whiteboard: [js:t]
OS: Mac OS X → All
Hardware: x86 → All
Assignee: general → bzbarsky
Whiteboard: [js:t] → [need review][js:t]
Comment on attachment 690034 [details] [diff] [review]
part 1.  Inline js::GetContextCompartment.

Review of attachment 690034 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jspubtd.h
@@ +271,2 @@
>      ContextFriendFields(JSRuntime *rt)
> +        : runtime(rt), compartment(NULL) { }

This was correctly indented two spaces.  {} really belongs on a new line, tho, if we're going to touch anything here.
Attachment #690034 - Flags: review?(jwalden+bmo) → review+
Comment on attachment 690035 [details] [diff] [review]
part 2.  Use the now-inline js::GetContextCompartment in a few places.

Review of attachment 690035 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #690035 - Flags: review?(jwalden+bmo) → review+
   https://hg.mozilla.org/integration/mozilla-inbound/rev/79c26e82dfeb
   https://hg.mozilla.org/integration/mozilla-inbound/rev/ea066846993c
Flags: in-testsuite-
Whiteboard: [need review][js:t] → [js:t]
Target Milestone: --- → mozilla20

Updated

7 years ago
Blocks: 821762

Updated

7 years ago
No longer blocks: 821762
You need to log in before you can comment on or make changes to this bug.