The default bug view has changed. See this FAQ.

"Assertion failure: dn->isClosed(),"

RESOLVED FIXED in mozilla17

Status

()

Core
JavaScript Engine
--
critical
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: gkw, Assigned: luke)

Tracking

(Blocks: 1 bug, {assertion, regression, testcase})

Trunk
mozilla17
x86
Mac OS X
assertion, regression, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 642188 [details]
stack

(function() {x})
((function() {x}) for (x in 2))

asserts js debug shell on m-c changeset 32c911bc2579 without any CLI arguments, but only when the testcase is passed in as a CLI parameter at Assertion failure: dn->isClosed(),

autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   99089:b790407d394f
user:        Luke Wagner
date:        Thu Jul 05 20:29:24 2012 -0700
summary:     Bug 771039 - assert some invariants in BindNameToSlot (r=dvander)
(Assignee)

Comment 1

5 years ago
Created attachment 642673 [details] [diff] [review]
fix and test

More pre-existing bugs in the genexpr CompExprTransplanter code:

So, before we know this is a genexpr, both (function() {x}) lambdas have finished parsing and share the same placeholder binding node in the enclosing (global) scope.  Then we see the second statement is a genexpr so we must transplant the use of 'x' to have a new placeholder.  To do this we make a new placeholder, but we lose the fact that the old placeholder was aliased so that when we convert the placeholder to a real binding (the 'x' in for(x in [0,1])), the definition isn't marked as closed.
Assignee: general → luke
Status: NEW → ASSIGNED
Attachment #642673 - Flags: review?(dvander)
Attachment #642673 - Flags: review?(dvander) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2958d924acc6
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/2958d924acc6
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
A testcase for this bug was automatically identified at js/src/jit-test/tests/basic/testBug773927.js.
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.