Closed Bug 773949 Opened 13 years ago Closed 13 years ago

Merge set default client functions in prefs

Categories

(SeaMonkey :: Preferences, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

Details

Attachments

(1 file)

Now that Bug 771954 has landed it potentially means the onSetDefault functions in pref-mailnews.js could be merged. Needs to be tested against windows build.
Attachment #642216 - Flags: feedback?(ewong)
(In reply to Ian Neal from comment #0) > Created attachment 642216 [details] [diff] [review] > Do the merge > > Now that Bug 771954 has landed it potentially means the onSetDefault > functions in pref-mailnews.js could be merged. > Needs to be tested against windows build. I was testing this patch and came across something I don't know if it's worth considering. I clicked on "Mail" and "news". Then I realized "How do I undo this change?" Is it worth to add some sort of backup thing that when clicked, it reverts the changes (and thusly re-enables the two buttons?) The 'permanancy' of this decision is a little scary. Of course, if the user has something else that can do the mail and/or news, that other app could just as well re-ask whether that app should be the default mail/News reader. (I don't.) I guess I can always go back into the about:config and change it. Just something to think about.
Attachment #642216 - Flags: feedback?(ewong) → feedback+
Attachment #642216 - Flags: review?(neil)
(In reply to Edmund Wong from comment #1) > "How do I undo this change?" You can't. Only the previously default app knows how to set itself back as default. > The 'permanancy' of this decision is a little scary. The Browser button has the slight advantage that it defers the setting until you click OK. (Obviously this wouldn't apply to Mac/Linux.)
Comment on attachment 642216 [details] [diff] [review] Do the merge [Checked in: Comment 4] I guess extracting the type from the button's id would have been too confusing ;-)
Attachment #642216 - Flags: review?(neil) → review+
Attachment #642216 - Attachment description: Do the merge → Do the merge [Checked in: Comment 4]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: